zipline: fix old upload copy from v3 to v4 (#5015)

* zipline: fix old upload copy from v3 to v4

* rm for install

Author: MickLesk

ct/zipline.sh

@@ -41,7 +41,9 @@ function update_script() {
     msg_info "Updating ${APP} to ${RELEASE}"
     cp /opt/zipline/.env /opt/
     mkdir -p /opt/zipline-upload
-    cp -R /opt/zipline/upload/* /opt/zipline-upload/
+    if [ -d /opt/zipline/upload ] && [ "$(ls -A /opt/zipline/upload)" ]; then
+      cp -R /opt/zipline/upload/* /opt/zipline-upload/
+    fi
     curl -fsSL "https://github.com/diced/zipline/archive/refs/tags/v${RELEASE}.zip" -o $(basename "https://github.com/diced/zipline/archive/refs/tags/v${RELEASE}.zip")
     $STD unzip v"${RELEASE}".zip
     rm -R /opt/zipline

install/zipline-install.sh

@@ -78,6 +78,7 @@ msg_ok "Created Service"
 motd_ssh
 customize
 msg_info "Cleaning up"
+rm -f /opt/v${RELEASE}.zip
 $STD apt-get -y autoremove
 $STD apt-get -y autoclean
 msg_ok "Cleaned"