Skip to content

Commit 906a0a0

Browse files
authored
Refactor ScriptItem and ConfigFile components to conditionally render config file location. Update ConfigFile to accept configPath prop instead of item. (#5197)
1 parent 8df55a0 commit 906a0a0

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

frontend/src/app/scripts/_components/ScriptItem.tsx

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ import { ResourceDisplay } from "./ResourceDisplay";
1515
import { getDisplayValueFromType } from "./ScriptInfoBlocks";
1616
import Alerts from "./ScriptItems/Alerts";
1717
import Buttons from "./ScriptItems/Buttons";
18+
import ConfigFile from "./ScriptItems/ConfigFile";
1819
import DefaultPassword from "./ScriptItems/DefaultPassword";
1920
import Description from "./ScriptItems/Description";
2021
import InstallCommand from "./ScriptItems/InstallCommand";
2122
import InterFaces from "./ScriptItems/InterFaces";
2223
import Tooltips from "./ScriptItems/Tooltips";
23-
import ConfigFile from "./ScriptItems/ConfigFile";
2424

2525
interface ScriptItemProps {
2626
item: Script;
@@ -152,16 +152,18 @@ export function ScriptItem({ item, setSelectedScript }: ScriptItemProps) {
152152
<div className="">
153153
<InstallCommand item={item} />
154154
</div>
155-
<Separator />
156-
<div className="flex gap-3 px-4 py-2 bg-accent/25">
157-
<h2 className="text-lg font-semibold">
158-
Location of config file
159-
</h2>
160-
</div>
161-
<Separator />
162-
<div className="">
163-
<ConfigFile item={item} />
164-
</div>
155+
{item.config_path && (
156+
<>
157+
<Separator />
158+
<div className="flex gap-3 px-4 py-2 bg-accent/25">
159+
<h2 className="text-lg font-semibold">Location of config file</h2>
160+
</div>
161+
<Separator />
162+
<div className="">
163+
<ConfigFile configPath={item.config_path} />
164+
</div>
165+
</>
166+
)}
165167
</div>
166168

167169
<DefaultPassword item={item} />
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import ConfigCopyButton from "@/components/ui/config-copy-button";
2-
import { Script } from "@/lib/types";
32

4-
export default function ConfigFile({ item }: { item: Script }) {
3+
export default function ConfigFile({ configPath }: { configPath: string }) {
54
return (
65
<div className="px-4 pb-4">
7-
<ConfigCopyButton>{item.config_path ? item.config_path : "No config path set"}</ConfigCopyButton>
6+
<ConfigCopyButton>{configPath}</ConfigCopyButton>
87
</div>
98
);
109
}

0 commit comments

Comments
 (0)