Fix: Trillium Update Function & Harmonize Installation (#2148)

* Fix Trillium Update Function

* Update trilium-install.sh

Author: MickLesk

ct/trilium.sh

@@ -32,29 +32,41 @@ function update_script() {
         msg_error "No ${APP} Installation Found!"
         exit
     fi
+    if [[ ! -f /opt/${APP}_version.txt ]]; then touch /opt/${APP}_version.txt
+    fi
+    if [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]] || [[ ! -f /opt/${APP}_version.txt ]]; then
     RELEASE=$(curl -s https://api.github.com/repos/TriliumNext/Notes/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
-
     msg_info "Stopping ${APP}"
     systemctl stop trilium
     sleep 1
     msg_ok "Stopped ${APP}"
 
     msg_info "Updating to ${RELEASE}"
+    mkdir -p /opt/trilium_backup
+    mv /opt/trilium/{db,dump-db} /opt/trilium_backup/
+    rm -rf /opt/trilium
+    cd /tmp
     wget -q https://github.com/TriliumNext/Notes/releases/download/${RELEASE}/TriliumNextNotes-linux-x64-${RELEASE}.tar.xz
     tar -xf TriliumNextNotes-linux-x64-${RELEASE}.tar.xz
-    cp -r trilium-linux-x64-server/* /opt/trilium/
+    mv trilium-linux-x64-server /opt/trilium
+    cp -r /opt/trilium_backup/{db,dump-db} /opt/trilium/
+    echo "${RELEASE}" >/opt/${APP}_version.txt
     msg_ok "Updated to ${RELEASE}"
 
     msg_info "Cleaning up"
-    rm -rf TriliumNextNotes-linux-x64-${RELEASE}.tar.xz trilium-linux-x64-server
+    rm -rf /tmp/TriliumNextNotes-linux-x64-${RELEASE}.tar.xz 
+    rm -rf /opt/trilium_backup
     msg_ok "Cleaned"
 
     msg_info "Starting ${APP}"
     systemctl start trilium
     sleep 1
     msg_ok "Started ${APP}"
     msg_ok "Updated Successfully"
-    exit
+  else
+    msg_ok "No update required. ${APP} is already at ${RELEASE}"
+  fi
+  exit
 }
 
 start

install/trilium-install.sh

@@ -2,8 +2,7 @@
 
 # Copyright (c) 2021-2025 tteck
 # Author: tteck (tteckster)
-# License: MIT
-# https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
+# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 
 source /dev/stdin <<< "$FUNCTIONS_FILE_PATH"
 color
@@ -14,23 +13,24 @@ network_check
 update_os
 
 msg_info "Installing Dependencies"
-$STD apt-get install -y curl
-$STD apt-get install -y sudo
-$STD apt-get install -y mc
+$STD apt-get install -y \
+  curl \
+  sudo \
+  mc
 msg_ok "Installed Dependencies"
 
+msg_info "Setup TriliumNext"
+cd /opt
 RELEASE=$(curl -s https://api.github.com/repos/TriliumNext/Notes/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
-
-msg_info "Installing TriliumNext"
 wget -q https://github.com/TriliumNext/Notes/releases/download/${RELEASE}/TriliumNextNotes-linux-x64-${RELEASE}.tar.xz
 tar -xf TriliumNextNotes-linux-x64-${RELEASE}.tar.xz
 mv trilium-linux-x64-server /opt/trilium
-msg_ok "Installed TriliumNext"
+echo "${RELEASE}" >"/opt/${APPLICATION}_version.txt"
+msg_ok "Setup TriliumNext"
 
 msg_info "Creating Service"
-service_path="/etc/systemd/system/trilium.service"
-
-echo "[Unit]
+cat <<EOF >/etc/systemd/system/trilium.service
+[Unit]
 Description=Trilium Daemon
 After=syslog.target network.target
 
@@ -43,15 +43,16 @@ TimeoutStopSec=20
 Restart=always
 
 [Install]
-WantedBy=multi-user.target" >$service_path
+WantedBy=multi-user.target
+EOF
 systemctl enable --now -q trilium
 msg_ok "Created Service"
 
 motd_ssh
 customize
 
 msg_info "Cleaning up"
+rm -rf /opt/TriliumNextNotes-linux-x64-${RELEASE}.tar.xz
 $STD apt-get -y autoremove
 $STD apt-get -y autoclean
-rm -rf TriliumNextNotes-linux-x64-${RELEASE}.tar.xz
 msg_ok "Cleaned"