remove debugf and duplicate codes

Author: MickLesk

misc/alpine-tools.func

@@ -1,7 +1,7 @@
 #!/bin/ash
 # shellcheck shell=ash
 
-# Erwartet vorhandene msg_* und optional $STD aus deinem Framework.
+# Expects existing msg_* functions and optional $STD from the framework.
 
 # ------------------------------
 # helpers

misc/build.func

@@ -87,7 +87,6 @@ if command -v curl >/dev/null 2>&1; then
   source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
   load_functions
   catch_errors
-  #echo "(build.func) Loaded core.func via curl"
 elif command -v wget >/dev/null 2>&1; then
   source <(wget -qO- https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/core.func)
   source <(wget -qO- https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
@@ -2242,7 +2241,7 @@ build_container() {
     esac
   fi
 
-  # IP (immer zwingend, Standard dhcp)
+  # IP (always required, default dhcp)
   NET_STRING+=",ip=${NET:-dhcp}"
 
   # Gateway
@@ -2834,12 +2833,12 @@ destroy_lxc() {
     return 1
   fi
 
-  # Abbruch bei Ctrl-C / Ctrl-D / ESC
+  # Abort on Ctrl-C / Ctrl-D / ESC
   trap 'echo; msg_error "Aborted by user (SIGINT/SIGQUIT)"; return 130' INT QUIT
 
   local prompt
   if ! read -rp "Remove this Container? <y/N> " prompt; then
-    # read gibt != 0 zurück bei Ctrl-D/ESC
+    # read returns non-zero on Ctrl-D/ESC
     msg_error "Aborted input (Ctrl-D/ESC)"
     return 130
   fi
@@ -3555,16 +3554,6 @@ create_lxc_container() {
 
   LOGFILE="/tmp/pct_create_${CTID}_$(date +%Y%m%d_%H%M%S)_${SESSION_ID}.log"
 
-  # # DEBUG: Show the actual command that will be executed
-  # echo "[DEBUG] ===== PCT CREATE COMMAND DETAILS ====="
-  # echo "[DEBUG] CTID: $CTID"
-  # echo "[DEBUG] Template: ${TEMPLATE_STORAGE}:vztmpl/${TEMPLATE}"
-  # echo "[DEBUG] PCT_OPTIONS (will be word-split):"
-  # echo "$PCT_OPTIONS" | sed 's/^/  /'
-  # echo "[DEBUG] Full command line:"
-  # echo "  pct create $CTID ${TEMPLATE_STORAGE}:vztmpl/${TEMPLATE} $PCT_OPTIONS"
-  # echo "[DEBUG] ========================================"
-
   msg_debug "pct create command: pct create $CTID ${TEMPLATE_STORAGE}:vztmpl/${TEMPLATE} $PCT_OPTIONS"
   msg_debug "Logfile: $LOGFILE"
 
@@ -3609,7 +3598,7 @@ create_lxc_container() {
             0) : ;; # success - container created, continue
             2)
               echo "Upgrade was declined. Please update and re-run:
-  apt update && apt install --only-upgrade pve-container lxc-pve"
+                apt update && apt install --only-upgrade pve-container lxc-pve"
               exit 231
               ;;
             3)
@@ -3641,7 +3630,7 @@ create_lxc_container() {
           0) : ;; # success - container created, continue
           2)
             echo "Upgrade was declined. Please update and re-run:
-  apt update && apt install --only-upgrade pve-container lxc-pve"
+              apt update && apt install --only-upgrade pve-container lxc-pve"
             exit 231
             ;;
           3)

misc/error_handler.func

@@ -90,12 +90,6 @@ explain_exit_code() {
   253) echo "MongoDB: Database not found" ;;
   254) echo "MongoDB: Fatal query error" ;;
 
-  # --- Proxmox Custom Codes ---
-  200) echo "Custom: Failed to create lock file" ;;
-  203) echo "Custom: Missing CTID variable" ;;
-  204) echo "Custom: Missing PCT_OSTYPE variable" ;;
-  205) echo "Custom: Invalid CTID (<100)" ;;
-  206) echo "Custom: CTID already in use (check 'pct list' and /etc/pve/lxc/)" ;;
   # --- Proxmox Custom Codes ---
   200) echo "Custom: Failed to create lock file" ;;
   203) echo "Custom: Missing CTID variable" ;;
@@ -119,24 +113,6 @@ explain_exit_code() {
   225) echo "Custom: No template available for OS/Version (check 'pveam available')" ;;
   231) echo "Custom: LXC stack upgrade/retry failed (outdated pve-container - check https://github.com/community-scripts/ProxmoxVE/discussions/8126)" ;;
 
-  # --- Default ---
-  *) echo "Unknown error" ;;
-  208) echo "Custom: Invalid configuration (DNS/MAC/Network format error)" ;;
-  209) echo "Custom: Container creation failed (check logs for pct create output)" ;;
-  210) echo "Custom: Cluster not quorate" ;;
-  211) echo "Custom: Timeout waiting for template lock (concurrent download in progress)" ;;
-  214) echo "Custom: Not enough storage space" ;;
-  215) echo "Custom: Container created but not listed (ghost state - check /etc/pve/lxc/)" ;;
-  216) echo "Custom: RootFS entry missing in config (incomplete creation)" ;;
-  217) echo "Custom: Storage does not support rootdir (check storage capabilities)" ;;
-  218) echo "Custom: Template file corrupted or incomplete download (size <1MB or invalid archive)" ;;
-  220) echo "Custom: Unable to resolve template path" ;;
-  221) echo "Custom: Template file exists but not readable (check file permissions)" ;;
-  222) echo "Custom: Template download failed after 3 attempts (network/storage issue)" ;;
-  223) echo "Custom: Template not available after download (storage sync issue)" ;;
-  225) echo "Custom: No template available for OS/Version (check 'pveam available')" ;;
-  231) echo "Custom: LXC stack upgrade/retry failed (outdated pve-container - check https://github.com/community-scripts/ProxmoxVE/discussions/8126)" ;;
-
   # --- Default ---
   *) echo "Unknown error" ;;
   esac