Standardize update success messages in scripts (#8757)

Author: MickLesk

ct/2fauth.sh

@@ -66,7 +66,7 @@ function update_script() {
     $STD apt -y autoclean
     $STD apt -y clean
     msg_ok "Cleanup Completed"
-    msg_ok "Updated Successfully"
+    msg_ok "Updated successfully!"
   fi
   exit
 }

ct/actualbudget.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash
 source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
 # Copyright (c) 2021-2025 community-scripts ORG
 # Author: MickLesk (CanbiZ)
@@ -44,14 +44,15 @@ function update_script() {
       msg_info "Starting Service"
       systemctl start actualbudget
       msg_ok "Started Service"
+      msg_ok "Updated successfully!"
     else
       msg_info "${APP} is already up to date"
     fi
   else
     msg_info "Old Installation Found, you need to migrate your data and recreate to a new container"
     msg_info "Please follow the instructions on the ${APP} website to migrate your data"
     msg_info "https://actualbudget.org/docs/backup-restore/backup"
-    exit 1
+    exit
   fi
   exit
 }

ct/adventurelog.sh

@@ -73,7 +73,7 @@ function update_script() {
     msg_info "Cleaning Up"
     rm -rf /opt/adventurelog-backup
     msg_ok "Cleaned"
-    msg_ok "Updated Successfully"
+    msg_ok "Updated successfully!"
   fi
   exit
 }

ct/agentdvr.sh

@@ -27,7 +27,7 @@ function update_script() {
     msg_error "No ${APP} Installation Found!"
     exit
   fi
-  
+
   RELEASE=$(curl -fsSL "https://www.ispyconnect.com/api/Agent/DownloadLocation4?platform=Linux64&fromVersion=0" | grep -o 'https://.*\.zip')
   if [[ "${RELEASE}" != "$(cat ~/.agentdvr 2>/dev/null)" ]] || [[ ! -f ~/.agentdvr ]]; then
     msg_info "Stopping service"
@@ -39,15 +39,14 @@ function update_script() {
     curl -fsSL "$RELEASE" -o $(basename "$RELEASE")
     $STD unzip -o Agent_Linux64*.zip
     chmod +x ./Agent
-    echo $RELEASE > ~/.agentdvr
+    echo $RELEASE >~/.agentdvr
     rm -rf Agent_Linux64*.zip
     msg_ok "Updated $APP"
 
     msg_info "Starting service"
     systemctl start AgentDVR
     msg_ok "Service started"
-
-    msg_ok "Updated $APP successfully"
+    msg_ok "Updated successfully!"
   else
     msg_ok "No update required. ${APP} is already at ${RELEASE}"
   fi

ct/alpine-adguard.sh

@@ -32,6 +32,7 @@ function update_script() {
   msg_info "Restarting AdGuard Home"
   $STD rc-service adguardhome restart
   msg_ok "Restarted AdGuard Home"
+  msg_ok "Updated successfully!"
   exit 0
 }
 

ct/alpine-bitmagnet.sh

@@ -24,7 +24,7 @@ function update_script() {
 
   if [[ ! -d /opt/bitmagnet ]]; then
     msg_error "No ${APP} Installation Found!"
-    exit 1
+    exit
   fi
   RELEASE=$(curl -fsSL https://api.github.com/repos/bitmagnet-io/bitmagnet/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
   if [ "${RELEASE}" != "$(cat /opt/bitmagnet_version.txt)" ] || [ ! -f /opt/bitmagnet_version.txt ]; then
@@ -71,7 +71,7 @@ function update_script() {
     rm -f "$temp_file"
     echo "${RELEASE}" >/opt/bitmagnet_version.txt
     $STD service bitmagnet start
-    msg_ok "Updated Successfully"
+    msg_ok "Updated successfully!"
   else
     msg_ok "No update required. ${APP} is already at ${RELEASE}"
   fi

ct/alpine-caddy.sh

@@ -32,6 +32,7 @@ function update_script() {
   msg_info "Restarting Caddy"
   rc-service caddy restart
   msg_ok "Restarted Caddy"
+  msg_ok "Updated successfully!"
   exit 0
 }
 

ct/alpine-docker.sh

@@ -37,6 +37,7 @@ function update_script() {
     case $CHOICE in
     1)
       $STD apk -U upgrade
+      msg_ok "Updated successfully!"
       exit
       ;;
     esac

ct/alpine-forgejo.sh

@@ -31,6 +31,7 @@ function update_script() {
   msg_info "Restarting Forgejo"
   $STD rc-service forgejo restart
   msg_ok "Restarted Forgejo"
+  msg_ok "Updated successfully!"
   exit 0
 }
 

ct/alpine-garage.sh

@@ -46,7 +46,7 @@ function update_script() {
     msg_info "Starting Service"
     rc-service garage start || rc-service garage restart
     msg_ok "Started Service"
-    msg_ok "Update Successfully!"
+    msg_ok "Updated successfully!"
   else
     msg_ok "No update required. Garage is already at ${GITEA_RELEASE}"
   fi