Address PR feedback to bring more in line with other scripts

Author: yry-dev

ct/komga.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
-# Copyright (c) 2024 madelyn
+# Copyright (c) 2021-2024 community-scripts ORG
 # Author: madelyn (DysfunctionalProgramming)
 # License: MIT
 # https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
@@ -17,9 +17,11 @@ cat <<"EOF"
 EOF
 }
 header_info
+check_container_storage
+check_container_resources
 echo -e "Loading..."
 APP="Komga"
-var_disk="4"
+var_disk="2"
 var_cpu="1"
 var_ram="2048"
 var_os="debian"
@@ -54,18 +56,27 @@ function default_settings() {
 
 function update_script() {
 header_info
-if [[ ! -d /opt/komga ]]; then msg_error "No ${APP} Installation Found!"; exit; fi
+if [[ ! -f /opt/komga ]]; then msg_error "No ${APP} Installation Found!"; exit; fi
 msg_info "Updating ${APP}"
 RELEASE=$(curl -s https://api.github.com/repos/gotson/komga/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
-if [[ ! -d /opt/komga/komga-${RELEASE}.jar ]]; then
+if [[ ! -f /opt/${APP}_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]]; then
+  msg_info "Stopping ${APP}"
   systemctl stop komga
-  msg_info "Downloading ${APP} v$RELEASE"
+  msg_ok "Stopped ${APP}"
+
+  msg_info "Updating ${APP} to $RELEASE"
   wget -q "https://github.com/gotson/komga/releases/download/v$RELEASE/komga-${RELEASE}.jar"
-  mkdir -p /opt/komga
-  mv -f komga-${RELEASE}.jar /opt/komga/komga-${RELEASE}.jar
+  mv -f komga-${RELEASE}.jar /opt/komga/komga.jar
+  echo "${RELEASE}" >/opt/${APP}_version.txt
+  msg_ok "Updated ${APP} to $RELEASE"
+
+  msg_info "Starting ${APP}"
   systemctl start komga
+  msg_ok "Started ${APP}"
+  msg_ok "Updated Successfully"
+else
+  msg_ok "No update required.  ${APP} ia already at ${RELEASE}."  
 fi
-msg_ok "Updated ${APP} to v$RELEASE"
 exit
 }
 

install/komga-install.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-# Copyright (c) 2024 madelyn
+# Copyright (c) 2021-2024 community-scripts ORG
 # Author: madelyn (DysfunctionalProgramming)
 # License: MIT
 # https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
@@ -14,35 +14,35 @@ network_check
 update_os
 
 msg_info "Installing Dependencies"
-$STD apt-get install -y curl
-$STD apt-get install -y openjdk-17-jre
+$STD apt-get install -y curl mc sudo openjdk-17-jre
 msg_ok "Installed Dependencies"
 
 RELEASE=$(curl -s https://api.github.com/repos/gotson/komga/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
 
 msg_info "Installing Komga"
 wget -q https://github.com/gotson/komga/releases/download/${RELEASE}/komga-${RELEASE}.jar
 mkdir -p /opt/komga
-mv -f komga-${RELEASE}.jar /opt/komga/komga-${RELEASE}.jar
-msg_ok "Installed Komga 😊"
+mv -f komga-${RELEASE}.jar /opt/komga/komga.jar
+echo "${RELEASE}" >"/opt/${APPLICATION}_version.txt"
+msg_ok "Installed Komga"
 
 msg_info "Creating Service"
-service_path="/etc/systemd/system/komga.service"
-
-echo "[Unit]
+cat <<EOF >/etc/systemd/system/komga.service
+[Unit]
 Description=Komga
 After=syslog.target network.target
-
 [Service]
-User=root
+UMask=0002
 Type=simple
-ExecStart=java -jar -Xmx2g komga-${RELEASE}.jar
 WorkingDirectory=/opt/komga/
+ExecStart=java -jar -Xmx2g komga.jar
 TimeoutStopSec=20
-Restart=always
-
+KillMode=process
+Restart=on-failure
 [Install]
-WantedBy=multi-user.target" >$service_path
+WantedBy=multi-user.target
+EOF
+systemctl -q daemon-reload
 systemctl enable --now -q komga
 msg_ok "Created Service"