Skip to content

Commit e580a5d

Browse files
MickLeskMickLesk
authored
Add external installer warnings and user confirmation (#7539)
Added explicit warnings and user confirmation prompts to install scripts that run external installers from third-party sources. Updated JSON metadata to remove warning notes about external sources, as the scripts now handle user notification and consent directly. This improves transparency and user safety during installation.
1 parent 9d059b2 commit e580a5d

15 files changed

+187
-70
lines changed

‎frontend/public/json/pialert.json‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,5 @@
3131
"username": null,
3232
"password": null
3333
},
34-
"notes": [
35-
{
36-
"text": "WARNING: Installation sources scripts outside of Community Scripts repo. Please check the source before installing.",
37-
"type": "warning"
38-
}
39-
]
34+
"notes": []
4035
}

‎frontend/public/json/plex.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@
3535
{
3636
"text": "With Privileged/Unprivileged Hardware Acceleration Support",
3737
"type": "info"
38-
},
39-
{
40-
"text": "WARNING: Installation sources scripts outside of Community Scripts repo. Please check the source before installing.",
41-
"type": "warning"
4238
}
4339
]
4440
}

‎frontend/public/json/podman-homeassistant.json‎

Lines changed: 45 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,48 @@
11
{
2-
"name": "Podman Home Assistant Container",
3-
"slug": "podman-homeassistant",
4-
"categories": [
5-
16
6-
],
7-
"date_created": "2024-04-29",
8-
"type": "ct",
9-
"updateable": true,
10-
"privileged": false,
11-
"interface_port": 8123,
12-
"documentation": "https://www.home-assistant.io/docs/",
13-
"website": "https://www.home-assistant.io/",
14-
"logo": "https://cdn.jsdelivr.net/gh/selfhst/icons/webp/home-assistant.webp",
15-
"config_path": "/var/lib/containers/storage/volumes/hass_config/_data",
16-
"description": "A standalone Podman container-based installation of Home Assistant Core means that the Home Assistant Core software is installed inside a container managed by Podman, separate from the host operating system. This provides a flexible and scalable solution for running the software, as the container can be easily moved between host systems or isolated from other processes for security. Podman is a popular open-source tool for managing containers that is similar to Docker, but designed for use on Linux systems without a daemon.\r\n\r\n\ud83d\udec8 If the LXC is created Privileged, the script will automatically set up USB passthrough.",
17-
"install_methods": [
18-
{
19-
"type": "default",
20-
"script": "ct/podman-homeassistant.sh",
21-
"resources": {
22-
"cpu": 2,
23-
"ram": 2048,
24-
"hdd": 16,
25-
"os": "debian",
26-
"version": "12"
27-
}
28-
}
29-
],
30-
"default_credentials": {
31-
"username": null,
32-
"password": null
2+
"name": "Podman Home Assistant Container",
3+
"slug": "podman-homeassistant",
4+
"categories": [
5+
16
6+
],
7+
"date_created": "2024-04-29",
8+
"type": "ct",
9+
"updateable": true,
10+
"privileged": false,
11+
"interface_port": 8123,
12+
"documentation": "https://www.home-assistant.io/docs/",
13+
"website": "https://www.home-assistant.io/",
14+
"logo": "https://cdn.jsdelivr.net/gh/selfhst/icons/webp/home-assistant.webp",
15+
"config_path": "/var/lib/containers/storage/volumes/hass_config/_data",
16+
"description": "A standalone Podman container-based installation of Home Assistant Core means that the Home Assistant Core software is installed inside a container managed by Podman, separate from the host operating system. This provides a flexible and scalable solution for running the software, as the container can be easily moved between host systems or isolated from other processes for security. Podman is a popular open-source tool for managing containers that is similar to Docker, but designed for use on Linux systems without a daemon.\r\n\r\n\ud83d\udec8 If the LXC is created Privileged, the script will automatically set up USB passthrough.",
17+
"install_methods": [
18+
{
19+
"type": "default",
20+
"script": "ct/podman-homeassistant.sh",
21+
"resources": {
22+
"cpu": 2,
23+
"ram": 2048,
24+
"hdd": 16,
25+
"os": "debian",
26+
"version": "12"
27+
}
28+
}
29+
],
30+
"default_credentials": {
31+
"username": null,
32+
"password": null
33+
},
34+
"notes": [
35+
{
36+
"text": "If the LXC is created Privileged, the script will automatically set up USB passthrough.",
37+
"type": "warning"
3338
},
34-
"notes": [
35-
{
36-
"text": "If the LXC is created Privileged, the script will automatically set up USB passthrough.",
37-
"type": "warning"
38-
},
39-
{
40-
"text": "config path: `/var/lib/containers/storage/volumes/hass_config/_data`",
41-
"type": "info"
42-
},
43-
{
44-
"text": "Options to Install Portainer or Portainer Agent",
45-
"type": "warning"
46-
},
47-
{
48-
"text": "WARNING: Installation sources scripts outside of Community Scripts repo. Please check the source before installing.",
49-
"type": "warning"
50-
}
51-
]
39+
{
40+
"text": "config path: `/var/lib/containers/storage/volumes/hass_config/_data`",
41+
"type": "info"
42+
},
43+
{
44+
"text": "Options to Install Portainer or Portainer Agent",
45+
"type": "warning"
46+
}
47+
]
5248
}

‎install/bunkerweb-install.sh‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,17 @@ $STD apt-get install -y lsb-release
1919
msg_ok "Installed Dependencies"
2020

2121
RELEASE=$(curl -fsSL https://api.github.com/repos/bunkerity/bunkerweb/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
22-
msg_info "Installing BunkerWeb v${RELEASE} (Patience)"
22+
msg_warn "WARNING: This script will run an external installer from a third-party source (install-bunkerweb.sh)."
23+
msg_warn "The following code is NOT maintained or audited by our repository."
24+
msg_warn "If you have any doubts or concerns, please review the installer code before proceeding:"
25+
msg_custom "${TAB3}${GATEWAY}${BGN}${CL}" "\e[1;34m" "→ https://github.com/bunkerity/bunkerweb/raw/v${RELEASE}/misc/install-bunkerweb.sh"
26+
echo
27+
read -r -p "${TAB3}Do you want to continue? [y/N]: " CONFIRM
28+
if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
29+
msg_error "Aborted by user. No changes have been made."
30+
exit 10
31+
fi
32+
msg_info "Installing BunkerWeb (Patience)"
2333
curl -fsSL -o install-bunkerweb.sh https://github.com/bunkerity/bunkerweb/raw/v${RELEASE}/misc/install-bunkerweb.sh
2434
chmod +x install-bunkerweb.sh
2535
$STD ./install-bunkerweb.sh --yes

‎install/casaos-install.sh‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,16 @@ setting_up_container
1313
network_check
1414
update_os
1515

16+
msg_warn "WARNING: This script will run an external installer from a third-party source (https://casaos.zimaspace.com/)."
17+
msg_warn "The following code is NOT maintained or audited by our repository."
18+
msg_warn "If you have any doubts or concerns, please review the installer code before proceeding:"
19+
msg_custom "${TAB3}${GATEWAY}${BGN}${CL}" "\e[1;34m" "→ https://get.casaos.io/"
20+
echo
21+
read -r -p "${TAB3}Do you want to continue? [y/N]: " CONFIRM
22+
if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
23+
msg_error "Aborted by user. No changes have been made."
24+
exit 10
25+
fi
1626
msg_info "Installing CasaOS (Patience)"
1727
DOCKER_CONFIG_PATH='/etc/docker/daemon.json'
1828
mkdir -p $(dirname $DOCKER_CONFIG_PATH)

‎install/channels-install.sh‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,17 @@ $STD apt-get install -y chromium
1818
$STD apt-get install -y xvfb
1919
msg_ok "Installed Dependencies"
2020

21+
msg_warn "WARNING: This script will run an external installer from a third-party source (https://getchannels.com)."
22+
msg_warn "The following code is NOT maintained or audited by our repository."
23+
msg_warn "If you have any doubts or concerns, please review the installer code before proceeding:"
24+
msg_custom "${TAB3}${GATEWAY}${BGN}${CL}" "\e[1;34m" "→ https://getchannels.com/dvr/setup.sh"
25+
echo
26+
read -r -p "${TAB3}Do you want to continue? [y/N]: " CONFIRM
27+
if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
28+
msg_error "Aborted by user. No changes have been made."
29+
exit 10
30+
fi
31+
2132
if [[ "$CTTYPE" == "0" ]]; then
2233
msg_info "Setting Up Hardware Acceleration"
2334
$STD apt-get -y install \

‎install/iobroker-install.sh‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,17 @@ msg_info "Installing Dependencies"
1717
$STD apt-get install -y ca-certificates
1818
msg_ok "Installed Dependencies"
1919

20+
msg_warn "WARNING: This script will run an external installer from a third-party source (https://iobroker.net/)."
21+
msg_warn "The following code is NOT maintained or audited by our repository."
22+
msg_warn "If you have any doubts or concerns, please review the installer code before proceeding:"
23+
msg_custom "${TAB3}${GATEWAY}${BGN}${CL}" "\e[1;34m" "→ https://iobroker.net/install.sh"
24+
echo
25+
read -r -p "${TAB3}Do you want to continue? [y/N]: " CONFIRM
26+
if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
27+
msg_error "Aborted by user. No changes have been made."
28+
exit 10
29+
fi
30+
2031
NODE_VERSION="22" setup_nodejs
2132

2233
msg_info "Installing ioBroker (Patience)"

‎install/jeedom-install.sh‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,17 @@ $STD apt-get install -y \
1919
git
2020
msg_ok "Dependencies installed"
2121

22+
msg_warn "WARNING: This script will run an external installer from a third-party source (https://github.com/jeedom/)."
23+
msg_warn "The following code is NOT maintained or audited by our repository."
24+
msg_warn "If you have any doubts or concerns, please review the installer code before proceeding:"
25+
msg_custom "${TAB3}${GATEWAY}${BGN}${CL}" "\e[1;34m" "→ https://raw.githubusercontent.com/jeedom/core/master/install/install.sh"
26+
echo
27+
read -r -p "${TAB3}Do you want to continue? [y/N]: " CONFIRM
28+
if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
29+
msg_error "Aborted by user. No changes have been made."
30+
exit 10
31+
fi
32+
2233
DEFAULT_BRANCH="master"
2334
REPO_URL="https://github.com/jeedom/core.git"
2435

‎install/kasm-install.sh‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,32 @@ setting_up_container
1313
network_check
1414
update_os
1515

16-
msg_info "Installing Kasm Workspaces"
1716
KASM_VERSION=$(curl -fsSL 'https://www.kasmweb.com/downloads' | grep -o 'https://kasm-static-content.s3.amazonaws.com/kasm_release_[^"]*\.tar\.gz' | head -n 1 | sed -E 's/.*release_(.*)\.tar\.gz/\1/')
17+
18+
msg_warn "WARNING: This script will run an external installer from a third-party source (https://www.kasmweb.com/)."
19+
msg_warn "The following code is NOT maintained or audited by our repository."
20+
msg_warn "If you have any doubts or concerns, please review the installer code before proceeding:"
21+
msg_custom "${TAB3}${GATEWAY}${BGN}${CL}" "\e[1;34m" "→ install.sh inside tar.gz https://kasm-static-content.s3.amazonaws.com/kasm_release_${KASM_VERSION}.tar.gz"
22+
echo
23+
read -r -p "${TAB3}Do you want to continue? [y/N]: " CONFIRM
24+
if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
25+
msg_error "Aborted by user. No changes have been made."
26+
exit 10
27+
fi
28+
29+
msg_info "Installing Kasm Workspaces"
1830
curl -fsSL -o "/opt/kasm_release_${KASM_VERSION}.tar.gz" "https://kasm-static-content.s3.amazonaws.com/kasm_release_${KASM_VERSION}.tar.gz"
1931
cd /opt
2032
tar -xf "kasm_release_${KASM_VERSION}.tar.gz"
2133
chmod +x /opt/kasm_release/install.sh
22-
printf 'y\ny\ny\n4\n' | bash /opt/kasm_release/install.sh > ~/kasm-install.output 2>&1
34+
printf 'y\ny\ny\n4\n' | bash /opt/kasm_release/install.sh >~/kasm-install.output 2>&1
2335
awk '
2436
/^Kasm UI Login Credentials$/ {capture=1}
2537
capture {print}
2638
/^Service Registration Token$/ {in_token=1}
2739
in_token && /^-+$/ {dash_count++}
2840
in_token && dash_count==2 {exit}
29-
' ~/kasm-install.output > ~/kasm.creds
41+
' ~/kasm-install.output >~/kasm.creds
3042
msg_ok "Installed Kasm Workspaces"
3143

3244
motd_ssh

‎install/mattermost-install.sh‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,17 @@ setting_up_container
1313
network_check
1414
update_os
1515

16+
msg_warn "WARNING: This script will run an external installer from a third-party source (https://mattermost.com/)."
17+
msg_warn "The following code is NOT maintained or audited by our repository."
18+
msg_warn "If you have any doubts or concerns, please review the installer code before proceeding:"
19+
msg_custom "${TAB3}${GATEWAY}${BGN}${CL}" "\e[1;34m" "→ https://deb.packages.mattermost.com/repo-setup.sh"
20+
echo
21+
read -r -p "${TAB3}Do you want to continue? [y/N]: " CONFIRM
22+
if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
23+
msg_error "Aborted by user. No changes have been made."
24+
exit 10
25+
fi
26+
1627
PG_VERSION="16" setup_postgresql
1728

1829
msg_info "Setting up PostgreSQL"

0 commit comments

Comments
 (0)