You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many scripts check the latest release version from github and then compare this to /opt/{$APP}_version.txt.
I think it would be nice if you could check if there are update to your LXCs from the proxmox shell, to give you an output like this (completely made up):
A possible way to do this, would be to split the current update function into two, where the new function update_check (or something) only handles the version comparison, which would then by used in the update function to do the actual update. That way:
update keeps working like it works now
the feature can be added to apps over time during a refactor/update
Checking the existence of update and update_check can be used to inform user if this is supported (see example above)
Could also work for non-github apps, then you will have a different update_check function
Completely open to different approaches as well, this was the 2nd second thought that came to mind.
My first thought was having a github repo link stored in some sort of json (like for the frontend information), but this will be more overhead. An advantage of this could be that you could do the latest release check using a github action, and then use this as cache for the update_check function, to avoid hammering the github API.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Many scripts check the latest release version from github and then compare this to
/opt/{$APP}_version.txt
.I think it would be nice if you could check if there are update to your LXCs from the proxmox shell, to give you an output like this (completely made up):
A possible way to do this, would be to split the current
update
function into two, where the new functionupdate_check
(or something) only handles the version comparison, which would then by used in the update function to do the actual update. That way:update
keeps working like it works nowupdate
andupdate_check
can be used to inform user if this is supported (see example above)update_check
functionCompletely open to different approaches as well, this was the 2nd second thought that came to mind.
My first thought was having a github repo link stored in some sort of json (like for the frontend information), but this will be more overhead. An advantage of this could be that you could do the latest release check using a github action, and then use this as cache for the
update_check
function, to avoid hammering the github API.Beta Was this translation helpful? Give feedback.
All reactions