Skip to content

Update qBittorrent installation check logic#13533

Closed
jackharvest wants to merge 1 commit intocommunity-scripts:mainfrom
jackharvest:patch-1
Closed

Update qBittorrent installation check logic#13533
jackharvest wants to merge 1 commit intocommunity-scripts:mainfrom
jackharvest:patch-1

Conversation

@jackharvest
Copy link
Copy Markdown

Change condition to check for existing qBittorrent config file. Previously, "v4" was being detected improperly due to a file check. We've removed the explanation point.

✍️ Description

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Change condition to check for existing qBittorrent config file. Previously, "v4" was being detected improperly due to a file check. We've removed the explanation point.
@jackharvest jackharvest requested a review from a team as a code owner April 5, 2026 16:57
@github-actions github-actions bot added the update script A change that updates a script label Apr 5, 2026
@CrazyWolf13
Copy link
Copy Markdown
Member

@jackharvest

1.) The PR Template was not filled out, please do so.

2.) The current system seems to work fine, as previously fetch_and_deploy_gh_release was not being used, which resulted in the version file (used by our fetch_and_deploy_gh_release-function) not existing, so this check seems valid to me.

Check this line in the current script: https://github.com/community-scripts/ProxmoxVE/blob/main/install/qbittorrent-install.sh#L16

3.) Please further elaborate the issue you ran into.

@jackharvest
Copy link
Copy Markdown
Author

@jackharvest

1.) The PR Template was not filled out, please do so.

2.) The current system seems to work fine, as previously fetch_and_deploy_gh_release was not being used, which resulted in the version file (used by our fetch_and_deploy_gh_release-function) not existing, so this check seems valid to me.

Check this line in the current script: https://github.com/community-scripts/ProxmoxVE/blob/main/install/qbittorrent-install.sh#L16

3.) Please further elaborate the issue you ran into.

Sorry, my experience for that explanation point was reversed. I’ve been stuck on version 5.2.x for months and months, and after finally sitting down to troubleshoot, this portion of the qbittorrent script was checking to see if a specific folder wasn’t there, which would force terminate into “4.x to 5.x isn’t supported. Rebuild LXC” or whatever.

Removing it made it check to see if the folder WAS there (which is true on v5 builds) and thus, updated it properly.

That was my experience, figured there may be others stuck on older app versions for the same reason.

@CrazyWolf13
Copy link
Copy Markdown
Member

CrazyWolf13 commented Apr 5, 2026

Normally .qbittorrent is a file containing the version that the function deployed:

grafik

I'm also not sure how you ended up stuck on 5.2.x for months, as there is only 5.1.4 released yet? https://github.com/userdocs/qbittorrent-nox-static/releases

The if check you modified here:
https://github.com/community-scripts/ProxmoxVE/blob/main/ct/qbittorrent.sh#L30

is checking for a file not a directory, so that would have nothing to do with the qbittorrent directory you were mentioning.

@CrazyWolf13 CrazyWolf13 closed this Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants