Update qBittorrent installation check logic#13533
Update qBittorrent installation check logic#13533jackharvest wants to merge 1 commit intocommunity-scripts:mainfrom
Conversation
Change condition to check for existing qBittorrent config file. Previously, "v4" was being detected improperly due to a file check. We've removed the explanation point.
|
1.) The PR Template was not filled out, please do so. 2.) The current system seems to work fine, as previously fetch_and_deploy_gh_release was not being used, which resulted in the version file (used by our fetch_and_deploy_gh_release-function) not existing, so this check seems valid to me. Check this line in the current script: https://github.com/community-scripts/ProxmoxVE/blob/main/install/qbittorrent-install.sh#L16 3.) Please further elaborate the issue you ran into. |
Sorry, my experience for that explanation point was reversed. I’ve been stuck on version 5.2.x for months and months, and after finally sitting down to troubleshoot, this portion of the qbittorrent script was checking to see if a specific folder wasn’t there, which would force terminate into “4.x to 5.x isn’t supported. Rebuild LXC” or whatever. Removing it made it check to see if the folder WAS there (which is true on v5 builds) and thus, updated it properly. That was my experience, figured there may be others stuck on older app versions for the same reason. |
|
Normally .qbittorrent is a file containing the version that the function deployed:
I'm also not sure how you ended up stuck on 5.2.x for months, as there is only 5.1.4 released yet? https://github.com/userdocs/qbittorrent-nox-static/releases The if check you modified here: is checking for a file not a directory, so that would have nothing to do with the qbittorrent directory you were mentioning. |

Change condition to check for existing qBittorrent config file. Previously, "v4" was being detected improperly due to a file check. We've removed the explanation point.
✍️ Description
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.