Wastebin install/update fails to download latest release

[dbeg]

✅ Have you read and understood the above guidelines?

YES

📜 What is the name of the script you are using?

Wastebin

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/wastebin.sh)"

⚙️ What settings are you using?

• Default Settings
• Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

📝 Provide a clear and concise description of the issue.

Originally when trying to perform an update on an existing community-script installation of Wastebin, I noted errors when the script was attempting to download the latest release of the wastebin project from GitHub. I then tested out a fresh install using the installer (bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/wastebin.sh)") which produced the same error.

🔄 Steps to reproduce the issue.

Step 1: Perform a fresh install of wastebin using the community-scripts installer.

❌ Paste the full error output (if available).

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/wastebin.sh)"
 _       __           __       __    _     
| |     / /___ ______/ /____  / /_  (_)___ 
| | /| / / __ `/ ___/ __/ _ \/ __ \/ / __ \
| |/ |/ / /_/ (__  ) /_/  __/ /_/ / / / / /
|__/|__/\__,_/____/\__/\___/_.___/_/_/ /_/ 
                                           
  ⚙️  Using Default Settings on node <REDACTED_PVE_NODE>
  🖥️  Operating System: debian
  🌟  Version: 12
  📦  Container Type: Unprivileged
  💾  Disk Size: 4 GB
  🧠  CPU Cores: 1
  🛠️  RAM Size: 1024 MiB
  🆔  Container ID: 102
  🚀  Creating a Wastebin LXC using the above default settings
  
  ✔️  Using local for Template Storage.
  ✔️  Using local-zfs for Container Storage.
  ✔️  Updated LXC Template List
  ✔️  LXC Template is ready to use.
  ✔️  LXC Container 102 was successfully created.
  ✔️   Started LXC Container
  ✔️  Set up Container OS
  ✔️  Network Connected: <REDACTED_IPV4> <REDACTED_IPV6> 
  ✔️  IPv4 Internet Connected
  ✖️  IPv6 Internet Not Connected
  ✔️  DNS Resolved github.com to 140.82.114.4
  ✔️  Updated Container OS
  ✔️  Core dependencies installed
 ⠼curl: (22) The requested URL returned error: 404
 ⠴
[ERROR] in line 19: exit code 0: while executing command curl -fsSL "https://github.com/matze/wastebin/releases/download/${RELEASE}/wastebin_${RELEASE}_x86_64-unknown-linux-musl.zip" -o "$temp_file"
curl: (22) The requested URL returned error: 400
/dev/fd/63: line 74: SPINNER_PID: unbound variable

🖼️ Additional context (optional).

When manually executing the relevant portion of the script, I see some partially valid output:

root@wastebin:~# curl -fsSL https://api.github.com/repos/matze/wastebin/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }'
3.1.0

Here we can see that we successfully extracted the latest tag_name from the repository in question and the output was 3.1.0, which at the time of opening this issue is indeed the latest release.

The next step of the installer script tries to download a zip file like so:

curl -fsSL "https://github.com/matze/wastebin/releases/download/${RELEASE}/wastebin_${RELEASE}_x86_64-unknown-linux-musl.zip" -o "$temp_file"

I suspect this might be the problem, as the interpolated URL of https://github.com/matze/wastebin/releases/download/3.1.0/wastebin_3.1.0_x86_64-unknown-linux-musl.zip produces an HTTP 404 response.

Hopping over to the actual release page within GitHub (https://github.com/matze/wastebin/releases/tag/3.1.0) I don't actually see any .zip binaries, but instead a .tar.zst (https://github.com/matze/wastebin/releases/download/3.1.0/wastebin_3.1.0_x86_64-unknown-linux-musl.tar.zst).

[MickLesk]

He have forgot to Upload an ZIP ^^ or now he only Upload tar. Idk, you can ask in His Repo

[dbeg]

He have forgot to Upload an ZIP ^^ or now he only Upload tar. Idk, you can ask in His Repo

I skimmed through many pages of recent releases for https://github.com/matze/wastebin and I don't see any .zip binaries (outside of Source code (zip) assets, although I don't think those types are desired here for this install, but I could be mistaken).

Example: https://github.com/matze/wastebin/archive/refs/tags/3.1.0.zip

[MickLesk]

In the big 3.0.0 (latest Script Update) was an "wastebin_3.0.0_x86_64-unknown-linux-musl.zip" (https://github.com/matze/wastebin/releases/download/3.0.0/wastebin_3.0.0_x86_64-unknown-linux-musl.zip) now its tar

[dbeg]

Ah, good catch. That release does indeed appear to be an outlier.

Would an appropriate path forward here be to modify the script to simply handle tars?

[MickLesk]

Yes, that's not a problem in itself, I just want to make sure that it is consistent and that the next release is not another zipfile.

[dbeg]

This issue has been addressed within #4934 which was already merged to main. Thanks for your quick communication on this one @MickLesk!