scripts add-iptag updates IPs of LXCs but not of VMs

[DST73]

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

add-iptag

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/tools/pve/add-iptag.sh)"

⚙️ What settings are you using?

• Default Settings
• Advanced Settings

🖥️ Which Linux distribution are you using?

No response

📝 Provide a clear and concise description of the issue.

The script only updates the IPs of the LXCs but not of my VMs

🔄 Steps to reproduce the issue.

run the scripts within proxmox shell

❌ Paste the full error output (if available).

---

🖼️ Additional context (optional).

[MickLesk]

When installed?

Service Output?

Config Output?

[DST73]

Installed some time ago and updated today

Service output:

Config file is empty

[MickLesk]

@DesertGamer maybe we should add an Guide, its everytime the Same?

[DesertGamer]

This is an interesting behavior and I'm investigating it with a test machine soon.

[Maxter3185]

Same error here. Installed the script maybe 2 weeks ago, but didn't have any VM at that moment so I didn't noticed that

[DesertGamer]

Tell me, please, are you trying to update the script instead of installing it from scratch?

[DesertGamer]

@Maxter3185, @DST73 The fact is that I checked the errors and found that the update algorithm is working incorrectly, I will make the necessary changes in the near future.

[DST73]

Ok thank you :)

[DesertGamer]

Guys, I'm sorry, I didn't have time to do all this at all. I wrote it down for myself and will try to roll out the fix in a couple of hours.

[Maxter3185]

Guys, I'm sorry, I didn't have time to do all this at all. I wrote it down for myself and will try to roll out the fix in a couple of hours.

@DesertGamer No worries! I've kinda fixed it yesterday (at least for me). Looking at the scripts I've found the newer version of the script moved the config files and the script from /opt/lxc-iptag to /opt/iptag, and the config file was missing in the second folder. Restarted the service and it worked.

What I've also found (I know I should open a new thread for this) is that this script is kinda heavy on the cpu time everytime it runs.

This is from the netdata console. I don't know if this is normal behaviour or not.

[DST73]

I tried the same and copied the iptag.conf and restarted the service

cp /opt/lxc-iptag/iptag.conf /opt/iptag

now my VMs get updated as well :)

[MickLesk]

Maybe we remove the old Install fully and then Install the new one? Not migrating, Just Check If the old exist and full remove it

@DesertGamer

[DesertGamer]

@MickLesk Look, initially I planned that people who would use the old script with this would be able to seamlessly switch to the new one, for this I wrote an update algorithm, after which I noticed that it was cleaned in the commit, perhaps not intentionally, which is why I just removed this algorithm in the latest version, as it turned out not all, I I would still add a seamless transition algorithm that would be useful to users who have previously used this script.