Increase and/or allow configuration of curl timeout for fetch_and_deploy_gh_release

[chrislo27]

📌 Task summary

Increase and/or allow configuration of curl timeout for fetch_and_deploy_gh_release

📋 Task details

The default timeout for curl in the fetch_and_deploy_gh_release tools function is 30 seconds. This can be too short for downloading larger releases (e.g. immich tarballs), and is also dependent on the user's network and GitHub's CDN servers. While it might work for some, it may not work for others.

Line where timeout values are set:

ProxmoxVE/misc/tools.func

Line 744 in 5cf8765

local curl_timeout="--connect-timeout 10 --max-time 30"

It would be good to increase the default timeout, allow it to be passed in as a parameter to the function, or remove it entirely.

[MickLesk]

That the timeout to get the Release Version number? I think its big enough for an json with <100kb (in very large Projects)

[vhsdream]

@MickLesk the timeout is also used here which downloads the release itself, and in several subsequent places.

[MickLesk]

And what is the preferred time?! I don't make it configurable, the function already has 6 different values either way.

[chrislo27]

I don't know why the original timeout exists so there may be a good reason for it to remain in the metadata fetch operations. Since there are already so many parameters in the function, it might be best to just remove the curl_timeout param for non-metadata fetching (or maybe just keep the connect timeout).

[MickLesk]

This is in there because many have Github blocks via Adblock or PiHole -> that means it would load endlessly or not even get that far.

[MickLesk]

I Check tomorrow the largest Releasefile that we use, then i calculate with 100kb/s + 50% as time, maybe this should enough.

[chrislo27]

Thanks! For reference I was updating immich to 1.135.3 https://github.com/immich-app/immich/releases/tag/v1.135.3 which downloads the source code tarball, and that's currently just over 70 MB.

[MickLesk]

done