Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

✍️ Description

The install and update scripts used different systemd service names, causing updates to fail. Install used speedtest_rs, update used librespeed_rs, neither matching the official package's librespeed-rs.service.

Changes:

  • install/librespeed-rust-install.sh: speedtest_rslibrespeed-rs
  • ct/librespeed-rust.sh: librespeed_rslibrespeed-rs (stop/start commands)

Both scripts now use librespeed-rs, matching the debian package from librespeed/speedtest-rust.

🔗 Related PR / Issue

Link: #4842

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.
Original prompt

This section details on the original issue you should resolve

<issue_title>Librespeed-rust install and update scripts use different .service names</issue_title>
<issue_description>### ✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

Librespeed Rust

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/librespeed-rust.sh)"

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

📈 Which Proxmox version are you on?

8.4.14

📝 Provide a clear and concise description of the issue.

The installation script and the update script use different names for the systemd service. In the installation script, it is set up as:

systemctl enable -q --now speedtest_rs

While the update script refers to:

systemctl start librespeed_rs

This causes a failure while updating. Curiously both these names are different than the librespeed-rs library's default system name which is

sudo systemctl enable librespeed-rs.service

🔄 Steps to reproduce the issue.

  1. You need to have a librespeed-rs installed. Mine is version 1.3.8.
  2. Run the update script in the container: bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/librespeed-rust.sh)"
  3. Notice the error.

❌ Paste the full error output (if available).

  ✔️   Update available: librespeed-rust 1.3.8 → 1.4.0
  ⏳   Stopping ServicesFailed to stop librespeed_rs.service: Unit librespeed_rs.service not loaded.

[ERROR] in line 33: exit code 0: while executing command systemctl stop librespeed_rs

🖼️ Additional context (optional).

No response</issue_description>

<agent_instructions>Servicenames are different in update/install, fix it</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix service name inconsistency in librespeed-rust scripts Fix service name mismatch between librespeed-rust install and update scripts Dec 3, 2025
Copilot AI requested a review from MickLesk December 3, 2025 17:06
@MickLesk MickLesk marked this pull request as ready for review December 3, 2025 20:01
@MickLesk MickLesk requested a review from a team as a code owner December 3, 2025 20:01
@MickLesk MickLesk merged commit cb7fb45 into main Dec 3, 2025
probers1 pushed a commit to probers1/ProxmoxVE that referenced this pull request Dec 5, 2025
…scripts (community-scripts#9628)

* Initial plan

* Fix service name inconsistency - use librespeed-rs for both install and update

Co-authored-by: MickLesk <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: MickLesk <[email protected]>
@MickLesk MickLesk deleted the copilot/fix-service-naming-issue branch December 8, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Librespeed-rust install and update scripts use different .service names

3 participants