Skip to content

Conversation

@MickLesk
Copy link
Member

@MickLesk MickLesk commented Dec 4, 2025

Extend storage type detection and add a little pre-flight validation.
=> Previously only supported: zfspool, dir, lvmthin, lvm, linstor

New supported storage types:

  • rbd (Ceph RBD)
  • nfs (Network File System)
  • cifs (SMB/CIFS shares)

New blocked storage types (incompatible with containers):

  • iscsidirect (212): VMs only
  • iscsi/zfs (213): no rootdir support
  • cephfs (219): use RBD instead
  • pbs (224): backup storage only

Network storage now includes connectivity check (exit 217 on failure):

  • linstor, rbd, nfs, cifs

Also reorganized Proxmox error codes (200-231) for consistency.

🔗 Related PR / Issue

Link: #https://discord.com/channels/1302816934508630047/1446107913423950005

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Improve storage validation for LXC container creation with
explicit checks for unsupported storage types.

Changes:
- Add validation for storage types that don't support containers:
  - iscsidirect (exit 212) - VMs only
  - iscsi/zfs (exit 213) - no rootdir support
  - cephfs (exit 219) - use RBD instead
  - pbs (exit 224) - backups only
- Add connectivity check for network storage (linstor, rbd, nfs, cifs)
- Simplify storage content validation using pvesm status
- Reorganize Proxmox error codes (200-231) for consistency
- Update error messages to be more descriptive and actionable

This helps users identify storage compatibility issues early
before container creation fails with cryptic errors.
@MickLesk MickLesk requested a review from a team as a code owner December 4, 2025 13:28
@github-actions github-actions bot added core update script A change that updates a script labels Dec 4, 2025
@MickLesk MickLesk changed the title core: extend storage type support and validation core: extend storage type support (rbd, nfs, cifs) and validation (iscidirect, isci, zfs, cephfs, pbs) Dec 4, 2025
@MickLesk MickLesk merged commit 0f7c201 into main Dec 4, 2025
1 check passed
probers1 pushed a commit to probers1/ProxmoxVE that referenced this pull request Dec 5, 2025
…cidirect, isci, zfs, cephfs, pbs) (community-scripts#9646)

* core: enhance storage type validation and error codes

Improve storage validation for LXC container creation with
explicit checks for unsupported storage types.

Changes:
- Add validation for storage types that don't support containers:
  - iscsidirect (exit 212) - VMs only
  - iscsi/zfs (exit 213) - no rootdir support
  - cephfs (exit 219) - use RBD instead
  - pbs (exit 224) - backups only
- Add connectivity check for network storage (linstor, rbd, nfs, cifs)
- Simplify storage content validation using pvesm status
- Reorganize Proxmox error codes (200-231) for consistency
- Update error messages to be more descriptive and actionable

This helps users identify storage compatibility issues early
before container creation fails with cryptic errors.

* Update build.func
@MickLesk MickLesk deleted the storage_feature branch December 8, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core feature update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants