Skip to content

Conversation

@pshankinclarke
Copy link
Contributor

✍️ Description

Automatic configuration of TLS gives users an easy option to encrypt Valkey traffic and protect the generated password without need to manually edit valkey.conf or reason about TLS details for each LXC instance.

I tested 3 cases (TLS disabled, TLS+TCP, TLS-only), checking valkey.conf, the listening ports, and valkey-cli with ping.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@pshankinclarke pshankinclarke requested a review from a team as a code owner December 9, 2025 00:42
@github-actions github-actions bot added feature update script A change that updates a script labels Dec 9, 2025
Comment on lines +46 to +50
openssl req -x509 -nodes -newkey rsa:2048 -days 3650 \
-subj "/CN=$(hostname)" \
-keyout "$TLS_DIR/valkey.key" \
-out "$TLS_DIR/valkey.crt" \
>/dev/null 2>&1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants