fix(skills): track Well-Read achievement properly

Author: softy-dev

apps/stardew.app/src/components/cards/dialog-card.tsx

@@ -27,7 +27,7 @@ import {
 } from "@/components/ui/dialog";
 
 import { useMultiSelect } from "@/contexts/multi-select-context";
-import { Stardrop, IslandUpgradeMail } from "@/lib/parsers/general";
+import { IslandUpgradeMail, Stardrop } from "@/lib/parsers/general";
 import { ChevronRightIcon } from "@radix-ui/react-icons";
 
 interface Props {
@@ -36,7 +36,14 @@ interface Props {
 	iconURL: string;
 	completed?: boolean;
 	_id: string;
-	_type: "stardrop" | "note" | "scrap" | "walnut" | "power" | "rarecrow" | "island_upgrade";
+	_type:
+		| "stardrop"
+		| "note"
+		| "scrap"
+		| "walnut"
+		| "power"
+		| "rarecrow"
+		| "island_upgrade";
 	/**
 	 * Whether the user prefers to see new content
 	 *
@@ -134,21 +141,20 @@ export const DialogCard = ({
 			case "power":
 				let powers = new Set(activePlayer?.powers?.collection ?? []);
 
-				console.log("initial powers:", powers);
-
 				if (status) powers.add(_id);
 				else powers.delete(_id);
 
-				console.log("final powers:", powers);
-
 				patch = {
 					powers: {
 						collection: Array.from(powers),
 					},
 				};
+				break;
 
 			case "island_upgrade":
-				const islandUpgrades = new Set(activePlayer.general?.islandUpgrades ?? []);
+				const islandUpgrades = new Set(
+					activePlayer.general?.islandUpgrades ?? [],
+				);
 				if (status) islandUpgrades.add(_id as IslandUpgradeMail);
 				else islandUpgrades.delete(_id as IslandUpgradeMail);
 

apps/stardew.app/src/pages/skills.tsx

@@ -58,10 +58,14 @@ export default function SkillsMasteryPowers() {
 					additionalDescription = ` - ${reqs[name] - maxLevelCount} left`;
 				}
 			} else if (powers.has(name)) {
-				// use the size of playerPowers and compare to reqs
-				if (playerPowers.size >= reqs[name]) completed = true;
+				// use the length of books from playerPowers and compare to reqs
+				const books = Array.from(playerPowers).filter((power) =>
+					power.startsWith("Book"),
+				);
+
+				if (books.length >= reqs[name]) completed = true;
 				else {
-					additionalDescription = ` - ${reqs[name] - playerPowers.size} left`;
+					additionalDescription = ` - ${reqs[name] - books.length} left`;
 				}
 			}
 		}