Merge pull request #1109 from TrellixVulnTeam/main

CVE-2007-4559 Patch

Author: chenkasirer

CHANGELOG.md

@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+* Patched [CVE-2007-4559](https://github.com/advisories/GHSA-gw9q-c7gh-j9vm) vulnerability.
 * Updated workflows to v2.
 * Fixed attribute error in `compas_rhino.conversions.ellipse_to_compas`.
 * Changed deepcopy of `RhinoBrep` to use the native `Rhino.Geometry` mechanism.

src/compas/__init__.py

@@ -303,7 +303,26 @@ def get_bunny(localstorage=None):
         urlretrieve(url, destination)
 
         with tarfile.open(destination) as file:
-            file.extractall(localstorage)
+
+            def is_within_directory(directory, target):
+
+                abs_directory = os.path.abspath(directory)
+                abs_target = os.path.abspath(target)
+
+                prefix = os.path.commonprefix([abs_directory, abs_target])
+
+                return prefix == abs_directory
+
+            def safe_extract(tar, path=".", members=None, numeric_owner=False):
+
+                for member in tar.getmembers():
+                    member_path = os.path.join(path, member.name)
+                    if not is_within_directory(path, member_path):
+                        raise Exception("Attempted Path Traversal in Tar File")
+
+                tar.extractall(path, members, numeric_owner=numeric_owner)
+
+            safe_extract(file, localstorage)
 
         os.remove(destination)