Merge pull request #1075 from compas-dev/cylinder-conversion-precision

Fix random failure of cylinder conversion from brep

Author: tomvanmele

CHANGELOG.md

@@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Based all gltf data classes on `BaseGLTFDataClass`
 * Fixed `Color.__get___` AttributeError.
 * Fixed `cylinder_to_rhino` conversion to match `compas.geometry.Cylinder` location.
+* Changed identification of cylinder brep face to non-zero in `compas_rhino.conversions.cylinder.Cylinder`.
 * Changed linter to `black`.
 * Automatically trigger `invoke format` during `invoke release`.
 * Fixed bug in `intersections.intersection_circle_circle_xy` where the Circle's Plane was accessed instead of the centre. 

src/compas_rhino/conversions/cylinder.py

@@ -46,7 +46,10 @@ def geometry(self, geometry):
                 faces = geometry.Faces
                 geometry = None
                 for face in faces:
-                    if face.IsCylinder():
+                    # being too strict about what is considered a cylinder
+                    # results in cylinders created by Rhino itself
+                    # to not be recognized...
+                    if face.IsCylinder(0.001):
                         result, geometry = face.TryGetFiniteCylinder(0.001)
                         if result:
                             break