fix vector comparison and add test

Author: tomvanmele

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Fixed `NotImplementedError` when calling `compas_rhino.conversions.surface_to_compas` on NURBS Surface.
 * Fixed `NotImplementedError` when calling `compas_rhino.conversions.surface_to_compas` on Surface.
 * Changed point comparison (`compas.geometry.Point.__eq__`) to use `TOL.is_allclose` instead of raw coordinate comparison.
+* Changed vector comparison (`compas.geometry.Vector.__eq__`) to use `TOL.is_allclose` instead of raw coordinate comparison.
 * Fixed bug in frame comparison (`compas.geometry.Frame.__eq__`).
 * Fixed bug in `compas.geometry.oriented_bounding_box_numpy`.
 

src/compas/geometry/frame.py

@@ -145,7 +145,7 @@ def __iter__(self):
     def __eq__(self, other):
         if not hasattr(other, "__iter__") or not hasattr(other, "__len__") or len(self) != len(other):
             return False
-        return TOL.is_allclose(self.point, other[0]) and TOL.is_allclose(self.xaxis, other[1]) and TOL.is_allclose(self.yaxis, other[2])
+        return self.point == other[0] and self.xaxis == other[1] and self.yaxis == other[2]
 
     # ==========================================================================
     # Properties

src/compas/geometry/vector.py

@@ -150,7 +150,7 @@ def __iter__(self):
         return iter([self.x, self.y, self.z])
 
     def __eq__(self, other):
-        return self.x == other[0] and self.y == other[1] and self.z == other[2]
+        return TOL.is_allclose(self, other)
 
     def __add__(self, other):
         return Vector(self.x + other[0], self.y + other[1], self.z + other[2])

tests/compas/geometry/test_vector.py

@@ -4,6 +4,7 @@
 import compas
 from random import random
 from compas.geometry import Vector
+from compas.tolerance import TOL
 
 
 @pytest.mark.parametrize(
@@ -95,6 +96,26 @@ def test_vector_equality():
     assert not (p1 == p3)
 
 
+def test_vector_comparison_relative():
+    a = Vector(random(), random(), random())
+    b = Vector(a.x + a.x * TOL.relative * 0.1, a.y + a.y * TOL.relative * 0.1, a.z + a.z * TOL.relative * 0.1)
+    c = Vector(a.x + a.x * TOL.relative, a.y + a.y * TOL.relative, a.z + a.z * TOL.relative)
+    d = Vector(a.x + a.x * TOL.relative * 10.0, a.y + a.y * TOL.relative * 10.0, a.z + a.z * TOL.relative * 10.0)
+    assert a == b
+    assert a == c
+    assert a != d
+
+
+def test_vector_comparison_absolute():
+    a = Vector(0, 0, 0)
+    b = Vector(a.x + TOL.absolute * 0.1, a.y + TOL.absolute * 0.1, a.z + TOL.absolute * 0.1)
+    c = Vector(a.x + TOL.absolute, a.y + TOL.absolute, a.z + TOL.absolute)
+    d = Vector(a.x + TOL.absolute * 10.0, a.y + TOL.absolute * 10.0, a.z + TOL.absolute * 10.0)
+    assert a == b
+    assert a == c
+    assert a != d
+
+
 def test_vector_inplace_operators():
     pass