Skip to content

Commit 42c1b71

Browse files
Copilotgonzalocasas
andcommitted
Move scaled() implementation to Shape base class to avoid duplication
Co-authored-by: gonzalocasas <[email protected]>
1 parent bd0252b commit 42c1b71

File tree

4 files changed

+23
-54
lines changed

4 files changed

+23
-54
lines changed

src/compas/geometry/shapes/capsule.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -348,24 +348,6 @@ def scale(self, factor):
348348
self.radius *= factor
349349
self.height *= factor
350350

351-
def scaled(self, factor):
352-
"""Returns a scaled copy of the capsule.
353-
354-
Parameters
355-
----------
356-
factor : float
357-
The scaling factor.
358-
359-
Returns
360-
-------
361-
:class:`compas.geometry.Capsule`
362-
The scaled capsule.
363-
364-
"""
365-
capsule = self.copy()
366-
capsule.scale(factor)
367-
return capsule
368-
369351
# =============================================================================
370352
# Methods
371353
# =============================================================================

src/compas/geometry/shapes/cylinder.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -318,24 +318,6 @@ def scale(self, factor):
318318
self.radius *= factor
319319
self.height *= factor
320320

321-
def scaled(self, factor):
322-
"""Returns a scaled copy of the cylinder.
323-
324-
Parameters
325-
----------
326-
factor : float
327-
The scaling factor.
328-
329-
Returns
330-
-------
331-
:class:`compas.geometry.Cylinder`
332-
The scaled cylinder.
333-
334-
"""
335-
cylinder = self.copy()
336-
cylinder.scale(factor)
337-
return cylinder
338-
339321
# =============================================================================
340322
# Methods
341323
# =============================================================================

src/compas/geometry/shapes/shape.py

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,13 +432,36 @@ def scale(self, scale):
432432
433433
See Also
434434
--------
435+
scaled
435436
translate
436437
rotate
437438
transform
438439
439440
"""
440441
raise NotImplementedError
441442

443+
def scaled(self, factor):
444+
"""Returns a scaled copy of the shape.
445+
446+
Parameters
447+
----------
448+
factor : float
449+
The scaling factor.
450+
451+
Returns
452+
-------
453+
:class:`compas.geometry.Shape`
454+
The scaled shape.
455+
456+
See Also
457+
--------
458+
scale
459+
460+
"""
461+
shape = self.copy()
462+
shape.scale(factor)
463+
return shape
464+
442465
# =============================================================================
443466
# Methods
444467
# =============================================================================

src/compas/geometry/shapes/sphere.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -280,24 +280,6 @@ def scale(self, factor):
280280
"""
281281
self.radius *= factor
282282

283-
def scaled(self, factor):
284-
"""Returns a scaled copy of the sphere.
285-
286-
Parameters
287-
----------
288-
factor : float
289-
The scaling factor.
290-
291-
Returns
292-
-------
293-
:class:`compas.geometry.Sphere`
294-
The scaled sphere.
295-
296-
"""
297-
sphere = self.copy()
298-
sphere.scale(factor)
299-
return sphere
300-
301283
# =============================================================================
302284
# Methods
303285
# =============================================================================

0 commit comments

Comments
 (0)