Merge pull request #1203 from compas-dev/frame-default-params-in-ctor

Optional args in frame constructor

Author: gonzalocasas

CHANGELOG.md

@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Pinned `jsonschema` version to >=4.17, <4.18 to avoid Rust toolchain
 * Fixed `box_to_compas` in `compas_rhino.conversions` to correctly take in the center of the box as the center point of the frame.
 * Removed `cython` from requirements.
+* Made X and Y axis optional in the constructor of `Frame`.
 
 ### Removed
 

src/compas/geometry/frame.py

@@ -31,10 +31,10 @@ class Frame(Geometry):
     ----------
     point : [float, float, float] | :class:`~compas.geometry.Point`
         The origin of the frame.
-    xaxis : [float, float, float] | :class:`~compas.geometry.Vector`
-        The x-axis of the frame.
-    yaxis : [float, float, float] | :class:`~compas.geometry.Vector`
-        The y-axis of the frame.
+    xaxis : [float, float, float] | :class:`~compas.geometry.Vector`, optional
+        The x-axis of the frame. Defaults to the unit X vector.
+    yaxis : [float, float, float] | :class:`~compas.geometry.Vector`, optional
+        The y-axis of the frame. Defaults to the unit Y vector.
 
     Attributes
     ----------
@@ -77,15 +77,15 @@ class Frame(Geometry):
         "required": ["point", "xaxis", "yaxis"],
     }
 
-    def __init__(self, point, xaxis, yaxis, **kwargs):
+    def __init__(self, point, xaxis=None, yaxis=None, **kwargs):
         super(Frame, self).__init__(**kwargs)
         self._point = None
         self._xaxis = None
         self._yaxis = None
         self._zaxis = None
         self.point = point
-        self.xaxis = xaxis
-        self.yaxis = yaxis
+        self.xaxis = xaxis or Vector(1, 0, 0)
+        self.yaxis = yaxis or Vector(0, 1, 0)
 
     def __repr__(self):
         return "{0}(point={1!r}, xaxis={2!r}, yaxis={3!r})".format(