Skip to content

Commit 510bb43

Browse files
committed
apply review comments
1 parent 81958ea commit 510bb43

File tree

1 file changed

+3
-5
lines changed
  • src/compas/datastructures/assembly

1 file changed

+3
-5
lines changed

src/compas/datastructures/assembly/part.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,10 @@ def geometry(self):
145145
# TODO: this is a temp solution
146146
# TODO: add memoization or some other kind of caching
147147
if self.features:
148-
A = Mesh.from_shape(self.shape)
148+
A = self.shape.to_vertices_and_faces(triangulated=True)
149149
for shape, operation in self.features:
150-
A.quads_to_triangles()
151-
B = Mesh.from_shape(shape)
152-
B.quads_to_triangles()
153-
A = Part.operations[operation](A.to_vertices_and_faces(), B.to_vertices_and_faces())
150+
B = shape.to_vertices_and_faces(triangulated=True)
151+
A = Part.operations[operation](A, B)
154152
geometry = Shape(*A)
155153
else:
156154
geometry = Shape(*self.shape.to_vertices_and_faces())

0 commit comments

Comments
 (0)