rename to cap_planar_holes

Author: papachap

CHANGELOG.md

@@ -10,7 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 * Added `Group` to `compas.scene`.
-* Added implementation of `make_solid` to `compas_rhino.geometry.RhinoBrep`.
+* Added `compas.geometry.Brep.cap_planar_holes`.
+* Added `compas_rhino.geometry.RhinoBrep.cap_planar_holes`.
 
 ### Changed
 

src/compas/geometry/brep/brep.py

@@ -923,11 +923,6 @@ def make_solid(self):
         -------
         None
 
-        Raises
-        ------
-        :class:`~compas.geometry.BrepInvalidError`
-            If the operation fails.
-
         """
         raise NotImplementedError
 
@@ -1144,3 +1139,23 @@ def overlap(self, other, deflection=None, tolerance=0.0):
 
         """
         raise NotImplementedError
+
+    def cap_planar_holes(self, tolerance=None):
+        """Cap all planar holes in the Brep.
+
+        Parameters
+        ----------
+        tolerance : float, optional
+            The precision to use for the operation. Defaults to `TOL.absolute`.
+
+        Returns
+        -------
+        None
+
+        Raises
+        ------
+        BrepError
+            If the operation fails.
+
+        """
+        raise NotImplementedError

src/compas_rhino/geometry/brep/brep.py

@@ -9,7 +9,6 @@
 from compas.geometry import Brep
 from compas.geometry import BrepError
 from compas.geometry import BrepFilletError
-from compas.geometry import BrepInvalidError
 from compas.geometry import BrepTrimmingError
 from compas.geometry import Frame
 from compas.geometry import Plane
@@ -676,17 +675,27 @@ def flip(self):
         """
         self._brep.Flip()
 
-    def make_solid(self):
-        """Convert the current shape to a solid if it is a shell.
+    def cap_planar_holes(self, tolerance=None):
+        """Cap all planar holes in the Brep.
+
+        Parameters
+        ----------
+        tolerance : float, optional
+            The precision to use for the operation. Defaults to `TOL.absolute`.
 
         Returns
         -------
         None
 
+        Raises
+        ------
+        BrepError
+            If the operation fails.
+
         """
-        if not self.is_solid:
-            result = self._brep.CapPlanarHoles(TOL.absolute)
-            if result:
-                self._brep = result
-            else:
-                raise BrepInvalidError("Failed to convert Brep to solid")
+        tolerance = tolerance or TOL.absolute
+        result = self._brep.CapPlanarHoles(tolerance)
+        if result:
+            self._brep = result
+        else:
+            raise BrepError("Failed to cap planar holes")