Merge pull request #1052 from compas-dev/rhino_box_bug

Rhino box bug

Author: tomvanmele

AUTHORS.md

@@ -33,3 +33,4 @@
 - Andrea Ghensi <<a.ghensi@swsglobal.com>> [@sanzoghenzo](https://github.com/sanzoghenzo)
 - Nizar Taha <<taha@arch.ethz.ch>> [@nizartaha](https://github.com/nizartaha)
 - Gene Ting-Chun Kao <<kao@arch.ethz.ch>> [@GeneKao](https://github.com/GeneKao)
+- Chen Kasirer <<kasirer@arch.ethz.ch>> [@chenkasirer](https://github.com/chenkasirer)

CHANGELOG.md

@@ -31,14 +31,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Rebuild part index after deserialization in `Assembly`.
 * Fixed bug in `compas.artists.colordict.ColorDict`.
 * Change `Mesh.mesh_dual` with option of including the boundary. 
-* Fixed type error in `compas_rhino.conversions._shapes.box_to_rhino`.
+* Fixed type error in `compas_rhino.conversions.box_to_rhino`.
 * Moved from `autopep8` to `black`
 * Fixed bug in `compas.utilities.linspace` for number series with high precision start and stop values.
 * Fixed uncentered viewbox in `Plotter.zoom_extents()`
 * Changed `RobotModelArtists.atteched_tool_models` to dictionary to support multiple tools.
 * Locked `sphinx` to 4.5.
 * Fixed source directory path in `compas_ghpython.uninstall` plugin.
 * Fixed bug in`compas_ghpython.components`that ignored input list of `.ghuser` objects to uninstall.
+* Fixed conversion bug of transformed `Box` in `compas_rhino.conversions`
 
 ### Removed
 

src/compas_rhino/conversions/_shapes.py

@@ -41,9 +41,9 @@ def box_to_compas(box):
     ysize = box.Y.Length
     zsize = box.Z.Length
     frame = plane_to_compas_frame(box.Plane)
-    frame.point.x += 0.5 * xsize
-    frame.point.y += 0.5 * ysize
-    frame.point.z += 0.5 * zsize
+    frame.point += frame.xaxis * 0.5 * xsize
+    frame.point += frame.yaxis * 0.5 * ysize
+    frame.point += frame.zaxis * 0.5 * zsize
     return Box(frame, xsize, ysize, zsize)
 
 
@@ -59,7 +59,12 @@ def box_to_rhino(box):
     :rhino:`Rhino.Geometry.Box`
 
     """
-    return RhinoBox(frame_to_rhino(box.frame), Interval(0., box.xsize), Interval(0., box.ysize), Interval(0., box.zsize))
+    # compas frame is center of box, intervals are in frame space
+    base_plane = box.frame.copy()
+    base_plane.point -= base_plane.xaxis * 0.5 * box.xsize
+    base_plane.point -= base_plane.yaxis * 0.5 * box.ysize
+    base_plane.point -= base_plane.zaxis * 0.5 * box.zsize
+    return RhinoBox(frame_to_rhino(base_plane), Interval(0, box.xsize), Interval(0, box.ysize), Interval(0, box.zsize))
 
 
 def sphere_to_compas(sphere):