Merge branch 'main' into mesh-strip-split

Author: tomvanmele

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Added halfedge loops in `compas.datastructures.Halfedge.halfedge_loop`.
 * Added halfedge strips in `compas.datastructures.Halfedge.halfedge_strip`.
 * Added `compas.datastructures.mesh_split_strip` and `compas.datastructures.Mesh.split_strip`.
+* Added boundingbox to `compas_rhino.conduits.BaseConduit`
 
 ### Changed
 

src/compas_rhino/conduits/base.py

@@ -36,6 +36,10 @@ def enabled(self):
         finally:
             self.disable()
 
+    def CalculateBoundingBox(self, e):
+        bbox = Rhino.Geometry.BoundingBox(-1000, -1000, -1000, 1000, 1000, 1000)
+        e.IncludeBoundingBox(bbox)
+
     def enable(self):
         """Enable the conduit."""
         self.Enabled = True

tests/compas/datastructures/test_halfedge.py

@@ -1,4 +1,5 @@
 import pytest
+import random
 
 import compas
 
@@ -344,6 +345,29 @@ def test_loops_and_strips_open_corner(grid):
     assert edge == loop[-1]
 
 
+def test_loops_and_strips_open_boundary(grid):
+    assert grid.number_of_edges() == 220
+
+    edge = random.choice(grid.edges_on_boundary())
+    u, v = edge
+
+    loop = grid.edge_loop(edge)
+    strip = grid.edge_strip(edge)
+    
+    assert edge in strip
+    assert len(strip) == 11
+    assert grid.is_edge_on_boundary(* strip[0])
+    assert grid.is_edge_on_boundary(* strip[-1])
+
+    assert edge in loop
+    assert len(loop) == 10
+
+    if grid.halfedge[u][v] is None:
+        assert edge == strip[-1]
+    else:
+        assert edge == strip[0]
+
+
 def test_split_strip_closed(box):
     edge = box.edge_sample()[0]
 
@@ -370,4 +394,3 @@ def test_split_strip_open_corner(grid):
 
     assert grid.is_valid()
     assert grid.number_of_faces() == 121
-