Skip to content

Commit 76af6d0

Browse files
committed
change _content.extensions to _content.extensions_used
1 parent 8eaebbe commit 76af6d0

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

src/compas/files/gltf/gltf_content.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ def __init__(self):
5959
self.images = {}
6060
self.extras = None
6161
self.extensions = None
62+
self.extensions_used = None
6263

6364
@property
6465
def default_or_first_scene(self):

src/compas/files/gltf/gltf_exporter.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ def load(self):
8989
None
9090
9191
"""
92+
print(self._content.textures)
9293
self._content.remove_orphans()
94+
print(self._content.textures)
9395
self._content.check_if_forest()
9496

9597
self._set_initial_gltf_dict()
@@ -179,10 +181,10 @@ def _add_extensions_recursively(self, item):
179181
self._add_extensions_recursively(getattr(item, a))
180182
if item.extensions is not None:
181183
for ek, e in item.extensions.items():
182-
if self._content.extensions is None:
183-
self._content.extensions = []
184-
if ek not in self._content.extensions:
185-
self._content.extensions.append(ek)
184+
if self._content.extensions_used is None: # attention: self._content.extension exists if we have general extensions.
185+
self._content.extensions_used = []
186+
if ek not in self._content.extensions_used:
187+
self._content.extensions_used.append(ek)
186188
self._add_extensions_recursively(e)
187189

188190
def _add_images(self):
@@ -209,10 +211,10 @@ def _construct_image_data_uri(self, image_data):
209211
return "data:" + (image_data.mime_type if image_data.mime_type else "") + ";base64," + base64.b64encode(image_data.data).decode("ascii")
210212

211213
def _add_extensions(self):
212-
if not self._content.extensions:
214+
if not self._content.extensions_used:
213215
return
214-
self._gltf_dict["extensionsRequired"] = self._content.extensions
215-
self._gltf_dict["extensionsUsed"] = self._content.extensions
216+
self._gltf_dict["extensionsRequired"] = self._content.extensions_used
217+
self._gltf_dict["extensionsUsed"] = self._content.extensions_used
216218

217219
def _add_samplers(self):
218220
if not self._content.samplers:

tests/compas/files/test_gltf.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,16 +145,15 @@ def test_specglossmetalrough(specglossmetalrough_gltf):
145145
gltf.read()
146146
exporter = gltf.exporter
147147
json.dumps(exporter._gltf_dict)
148-
assert exporter._content.extensions == ["KHR_materials_pbrSpecularGlossiness"]
148+
assert exporter._content.extensions_used == ["KHR_materials_pbrSpecularGlossiness"]
149149

150150

151151
def test_specular(specular_gltf):
152152
gltf = GLTF(specular_gltf)
153153
gltf.read()
154154
exporter = gltf.exporter
155155
json.dumps(exporter._gltf_dict)
156-
assert exporter._content.extensions == ["KHR_materials_specular"]
157-
print(exporter._content.extensions)
156+
assert exporter._content.extensions_used == ["KHR_materials_specular"]
158157

159158

160159
def test_gltf_content():

0 commit comments

Comments
 (0)