copy guid

Author: tomvanmele

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Added instructions for creating new data types to the dev guide.
 * Added `compact=False`, `minimal=False` to `compas.data.Data.to_json()` to `compas.data.Data.to_jsonstring()`.
+* Added `copy_guid=False` to `compas.data.Data.copy()`. If true, the copy has the same guid as the original.
 
 ### Changed
 

src/compas/data/data.py

@@ -272,14 +272,16 @@ def to_jsonstring(self, pretty=False, compact=False, minimal=False):
         """
         return compas.json_dumps(self, pretty=pretty, compact=compact, minimal=minimal)
 
-    def copy(self, cls=None):  # type: (...) -> D
+    def copy(self, cls=None, copy_guid=False):  # type: (...) -> D
         """Make an independent copy of the data object.
 
         Parameters
         ----------
         cls : Type[:class:`compas.data.Data`], optional
             The type of data object to return.
             Defaults to the type of the current data object.
+        copy_guid : bool, optional
+            If True, the copy will have the same guid as the original.
 
         Returns
         -------
@@ -291,7 +293,9 @@ def copy(self, cls=None):  # type: (...) -> D
             cls = type(self)
         obj = cls.__from_data__(deepcopy(self.__data__))
         if self._name is not None:
-            obj._name = self._name
+            obj._name = self.name
+        if copy_guid:
+            obj._guid = self.guid
         return obj  # type: ignore
 
     def sha256(self, as_string=False):

tests/compas/data/test_copy.py

@@ -7,15 +7,57 @@ def __data__(self):
         return {}
 
 
-def test_copy():
+def test_copy_noname():
     data = TestData()
 
+    assert data._name is None
+    assert data.name == "TestData"
+
+    assert data.copy()._name is None
+    assert data.copy().name == "TestData"
+
+    assert data.name == data.copy().name
+    assert data.__dtype__ == data.copy().__dtype__
+
+    assert data.guid != data.copy().guid
+    assert data.guid == data.copy(copy_guid=True).guid
+
+    assert data.__jsondump__() != data.copy().__jsondump__()
+    assert data.__jsondump__() == data.copy(copy_guid=True).__jsondump__()
+
+    assert data.to_jsonstring() != data.copy().to_jsonstring()
+    assert data.to_jsonstring() == data.copy(copy_guid=True).to_jsonstring()
+
+    assert data.__jsondump__(minimal=True) == data.copy().__jsondump__(minimal=True)
+    assert data.__jsondump__(minimal=True) == data.copy(copy_guid=False).__jsondump__(minimal=True)
+
+    assert data.to_jsonstring(minimal=True) == data.copy().to_jsonstring(minimal=True)
+    assert data.to_jsonstring(minimal=True) == data.copy(copy_guid=False).to_jsonstring(minimal=True)
+
+
+def test_copy():
+    data = TestData(name="test")
+
+    assert data._name == "test"
+    assert data.name == "test"
+
+    assert data.copy()._name == "test"
+    assert data.copy().name == "test"
+
     assert data.name == data.copy().name
     assert data.__dtype__ == data.copy().__dtype__
 
     assert data.guid != data.copy().guid
+    assert data.guid == data.copy(copy_guid=True).guid
+
     assert data.__jsondump__() != data.copy().__jsondump__()
+    assert data.__jsondump__() == data.copy(copy_guid=True).__jsondump__()
+
     assert data.to_jsonstring() != data.copy().to_jsonstring()
+    assert data.to_jsonstring() == data.copy(copy_guid=True).to_jsonstring()
 
     assert data.__jsondump__(minimal=True) == data.copy().__jsondump__(minimal=True)
+    assert data.__jsondump__(minimal=True) == data.copy(copy_guid=False).__jsondump__(minimal=True)
+
     assert data.to_jsonstring(minimal=True) == data.copy().to_jsonstring(minimal=True)
+    assert data.to_jsonstring(minimal=True) == data.copy(copy_guid=False).to_jsonstring(minimal=True)