Skip to content

Commit 7b3fac6

Browse files
committed
removed OCC specific properties from interface
1 parent 7a6ad22 commit 7b3fac6

File tree

3 files changed

+5
-47
lines changed

3 files changed

+5
-47
lines changed

CHANGELOG.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
## Unreleased
99

1010
### Added
11+
1112
* Implemented `to_points` method in `compas.datastructures.Mesh`, which before raised a `NotImplementedError`.
1213
* Implemented `compute_aabb` method in `compas.datastructures.Datastructure`, which before raised a `NotImplementedError`. Made use of the `compas.geometry.bbox.bounding_box` function.
1314
* Implemented `compute_obb` method in `compas.datastructures.Datastructure`, which before raised a `NotImplementedError`. Made use of the `compas.geometry.bbox_numpy.oriented_bounding_box_numpy` function.
@@ -20,8 +21,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2021
* Added missing property `centroid` in `compas_rhino.geometry.RhinoBrep`.
2122
* Added missing property `curves` in `compas_rhino.geometry.RhinoBrep`.
2223
* Added missing property `is_closed` in `compas_rhino.geometry.RhinoBrep`.
23-
* Added missing property `is_compound` in `compas_rhino.geometry.RhinoBrep`.
24-
* Added missing property `is_compoundsolid` in `compas_rhino.geometry.RhinoBrep`.
2524
* Added missing property `is_orientable` in `compas_rhino.geometry.RhinoBrep`.
2625
* Added missing property `is_surface` in `compas_rhino.geometry.RhinoBrep`.
2726
* Added missing property `is_valid` in `compas_rhino.geometry.RhinoBrep`.
@@ -42,6 +41,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4241

4342
### Removed
4443

44+
* Removed property `is_compound` from `compas.geometry.Brep` as OCC specific.
45+
* Removed property `is_compoundsolid` from `compas.geometry.Brep` as OCC specific.
46+
* Removed property `solids` from `compas.geometry.Brep` as OCC specific.
47+
* Removed property `shells` from `compas.geometry.Brep` as OCC specific.
4548

4649
## [2.13.0] 2025-06-04
4750

src/compas/geometry/brep/brep.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -177,30 +177,10 @@ def native_brep(self):
177177
def orientation(self):
178178
raise NotImplementedError
179179

180-
@property
181-
def type(self):
182-
raise NotImplementedError
183-
184180
@property
185181
def is_valid(self):
186182
raise NotImplementedError
187183

188-
@property
189-
def is_shell(self):
190-
raise NotImplementedError
191-
192-
@property
193-
def is_solid(self):
194-
raise NotImplementedError
195-
196-
@property
197-
def is_compound(self):
198-
raise NotImplementedError
199-
200-
@property
201-
def is_compoundsolid(self):
202-
raise NotImplementedError
203-
204184
@property
205185
def is_orientable(self):
206186
raise NotImplementedError

src/compas_rhino/geometry/brep/brep.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -236,16 +236,6 @@ def is_closed(self):
236236
assert self._brep
237237
return self._brep.IsSolid
238238

239-
@property
240-
def is_compound(self):
241-
# TODO: clarify. according to the internets compound brep is actually a container for several breps, not sure that's possible with a Rhino Brep.
242-
return False
243-
244-
@property
245-
def is_compoundsolid(self):
246-
# TODO: see above
247-
return False
248-
249239
@property
250240
def is_convex(self):
251241
raise NotImplementedError("Convexity check is not implemented for Rhino Breps.")
@@ -281,26 +271,11 @@ def orientation(self):
281271
# TODO: align this with compas.geometry.BrepOrientation
282272
return self._brep.SolidOrientation
283273

284-
@property
285-
def shells(self):
286-
# TODO: can create shell from brep but have to specify which faces to eliminate in order to hollow out the brep, doesn't seem like the intention.
287-
# TODO: is this about traversing a compound brep?
288-
raise NotImplementedError("Shells are not implemented for Rhino Breps.")
289-
290-
@property
291-
def solids(self):
292-
# TODO: same as above
293-
raise NotImplementedError("Solids are not implemented for Rhino Breps.")
294-
295274
@property
296275
def surfaces(self):
297276
assert self._brep
298277
return [[RhinoNurbsSurface.from_native(s.ToNurbsSurface()) for s in self._brep.Surfaces]]
299278

300-
@property
301-
def type(self):
302-
# TODO: seems like an OCC specific thinh, rename to occ_type and remove from interface?
303-
raise NotImplementedError("Type is not implemented for Rhino Breps.")
304279

305280
# ==============================================================================
306281
# Constructors

0 commit comments

Comments
 (0)