Skip to content

Commit 7bbe6ac

Browse files
authored
Merge pull request #1418 from compas-dev/nurbssurfac_from_native
fixed plugin not called in NurbsSurface
2 parents 3b38816 + a761aca commit 7bbe6ac

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
### Changed
1313

14+
* Fixed `NotImplementedError` when calling `compas_rhino.conversions.surface_to_compas` on NURBS Surface.
15+
* Fixed `NotImplementedError` when calling `compas_rhino.conversions.surface_to_compas` on Surface.
16+
1417
### Removed
1518

1619

src/compas/geometry/surfaces/nurbs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ def from_native(cls, surface):
392392
:class:`compas.geometry.NurbsSurface`
393393
394394
"""
395-
raise NotImplementedError
395+
return nurbssurface_from_native(cls, surface)
396396

397397
@classmethod
398398
def from_parameters(

src/compas/geometry/surfaces/surface.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def from_native(cls, surface):
160160
A COMPAS surface.
161161
162162
"""
163-
raise NotImplementedError
163+
return surface_from_native(cls, surface)
164164

165165
@classmethod
166166
def from_obj(cls, filepath):

0 commit comments

Comments
 (0)