Merge pull request #804 from mattiskoh/polyline_fixes

Polyline fixes

Author: beverlylytle

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+
 ### Added
 
 * Added Python 3.9 support.
@@ -19,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 * Fixed box scaling.
+* Fixed a bug in `Polyline.divide_polyline_by_length` related to a floating point rounding error.
 
 ### Removed
 

src/compas/geometry/primitives/polyline.py

@@ -266,7 +266,7 @@ def transform(self, T):
     def split_at_corners(self, angle_threshold):
         """Splits a polyline at corners larger than the given angle_threshold
 
-        Parameters:
+        Parameters
         -----------
         angle_threshold : float
             In radians.
@@ -311,7 +311,7 @@ def split_at_corners(self, angle_threshold):
     def tangent_at_point_on_polyline(self, point):
         """Calculates the tangent vector of a point on a polyline
 
-        Parameters:
+        Parameters
         -----------
         point: :class:`compas.geometry.Point`
 
@@ -327,7 +327,7 @@ def tangent_at_point_on_polyline(self, point):
     def divide_polyline(self, num_segments):
         """Divide a polyline in equal segments.
 
-        Parameters:
+        Parameters
         -----------
         num_segments : int
 
@@ -340,16 +340,19 @@ def divide_polyline(self, num_segments):
 
         return self.divide_polyline_by_length(segment_length, False)
 
-    def divide_polyline_by_length(self, length, strict=True):
-        """Splits a polyline in segments of a given length
+    def divide_polyline_by_length(self, length, strict=True, tol=1e-06):
+        """Splits a polyline in segments of a given length.
 
-        Parameters:
+        Parameters
         -----------
         length : float
 
         strict : bool
             If set to ``False``, the remainder segment will be added even if it is smaller than the desired length
 
+        tol : float
+            floating point error tolerance
+
         Returns
         -------
         list
@@ -379,7 +382,7 @@ def divide_polyline_by_length(self, length, strict=True):
 
         if strict is False and not self.is_closed() and len(division_pts) < num_pts+1:
             division_pts.append(new_polyline.points[-1])
-        elif strict is False and division_pts[-1] != self.points[-1]:
+        elif strict is False and division_pts[-1].distance_to_point(self.points[-1]) > tol:
             division_pts.append(self.points[-1])
 
         return division_pts