Merge pull request #1466 from compas-dev/brep_serialization

Brep serialization

Author: chenkasirer

CHANGELOG.md

@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+* Fixed error in `circle_to_compas` from Rhino.
+* Fixed Rhino to Rhino brep serialization.
+
 ### Removed
 
 

src/compas_rhino/conversions/curves.py

@@ -215,7 +215,7 @@ def circle_to_compas(circle):
     :class:`compas.geometry.Circle`
 
     """
-    frame = plane_to_compas(circle.Plane)
+    frame = plane_to_compas_frame(circle.Plane)
     return Circle(circle.Radius, frame=frame)
 
 

src/compas_rhino/geometry/brep/face.py

@@ -208,7 +208,7 @@ def _get_surface_geometry(surface):
         if isinstance(surface, Rhino.Geometry.NurbsSurface):
             _, plane = surface.FrameAt(0.0, 0.0)
             return "nurbs", RhinoNurbsSurface.from_rhino(surface), uv_domain, plane
-        if isinstance(surface, Rhino.Geometry.Rhino.Geometry.RevSurface):
+        if isinstance(surface, Rhino.Geometry.RevSurface):
             success, cast_surface = surface.TryGetSphere()
             if success:
                 return "sphere", sphere_to_compas(cast_surface), uv_domain, cast_surface.EquatorialPlane

src/compas_rhino/geometry/brep/trim.py

@@ -77,7 +77,11 @@ def __from_data__(cls, data, builder):
         """
         instance = cls()
         curve = RhinoNurbsCurve.__from_data__(data["curve"]).rhino_curve
-        iso_status = getattr(Rhino.Geometry.IsoStatus, data["iso"])
+        try:
+            iso_status = getattr(Rhino.Geometry.IsoStatus, data["iso"])
+        except AttributeError:
+            # due to discrepancy in how IsoStatus.None looks like in Rhino7 vs Rhino8 (`IsoStatus.NONE`)
+            iso_status = Rhino.Geometry.IsoStatus.NONE
         is_reversed = True if data["is_reversed"] == "true" else False
         instance.native_trim = builder.add_trim(curve, data["edge"], is_reversed, iso_status, data["start_vertex"])
         return instance