bug fix on is_polygon_in_polygon_xy

Author: baehrjo

CHANGELOG.md

@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Fixed `AttributeError` in Plotter's `PolylineArtist` and `SegementArtist`.
 * Fixed wrong key type when de-serializing `Graph` with integer keys leading to node not found.
 * Fixed bug in `VolMeshArtist.draw_cells` for Rhino, Blender and Grasshopper.
+* Fixed bug in the `is_polygon_in_polygon_xy` that was not correctly generating all the edges of the second polygon before checking for intersections.
 
 ### Removed
 

src/compas/geometry/predicates/predicates_2.py

@@ -383,7 +383,7 @@ def is_polygon_in_polygon_xy(polygon1, polygon2):
         for i in range(len(polygon1)):
             line = [polygon1[-i], polygon1[-i - 1]]
             for j in range(len(polygon2)):
-                line_ = [polygon2[-j], polygon2[j - 1]]
+                line_ = [polygon2[-j], polygon2[-j - 1]]
                 if is_intersection_segment_segment_xy(line, line_):
                     return False
         for pt in polygon2: