Skip to content

Commit 90cfd64

Browse files
authored
Merge pull request #1263 from compas-dev/brep_trim_cap
2 parents dc3e255 + d2bf8fd commit 90cfd64

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1717
* Merged `compas.datastructures.Halfedge` into `compas.datastructures.Mesh`.
1818
* Merged `compas.datastructures.Network` into `compas.datastructures.Graph`.
1919
* Merged `compas.datastructures.Halfface` into `compas.datastructures.VolMesh`.
20+
* Fixed `RhinoBrep` doesn't get capped after trimming.
2021

2122
### Removed
2223

src/compas_rhino/geometry/brep/brep.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,9 @@ def trimmed(self, plane, tolerance=TOLERANCE):
379379

380380
breps = []
381381
for result in results:
382-
result.CapPlanarHoles(TOLERANCE)
382+
capped = result.CapPlanarHoles(TOLERANCE)
383+
if capped:
384+
result = capped
383385
breps.append(RhinoBrep.from_native(result))
384386
return breps
385387

0 commit comments

Comments
 (0)