create edges from trims

Author: chenkasirer

src/compas_rhino/geometry/brep/brep.py

@@ -103,7 +103,7 @@ def points(self):
     @property
     def edges(self):
         if self._brep:
-            return [RhinoBrepEdge(edge) for edge in self._brep.Edges]
+            return [RhinoBrepEdge(trim) for trim in self._brep.Trims]
 
     @property
     def loops(self):

src/compas_rhino/geometry/brep/edge.py

@@ -15,16 +15,20 @@
 
 
 class RhinoBrepEdge(BrepEdge):
-    """A wrapper for Rhino.Geometry.BrepEdge
+    """A wrapper for Rhino.Geometry.BrepEdge.
+
+    The expected native type here is a Rhino.Geometry.BrepTrim.
+    a BrepTrim holds a reference to its associated BrepEdge as well as its start a end vertices
+    in a correct topological order (!).
 
     Attributes
     ----------
     curve : :class:`Rhino.Geometry.Curve3D`
         The underlying geometry of this edge.
     start_vertex : :class:`~compas_rhino.geometry.RhinoBrepVertex`, read-only
-        The start vertex of this edge.
+        The start vertex of this edge (taken from BrepTrim).
     end_vertex : :class:`~compas_rhino.geometry.RhinoBrepVertex`, read-only
-        The end vertex of this edge.
+        The end vertex of this edge (taken from BrepTrim).
     vertices : list[:class:`~compas_rhino.geometry.RhinoBrepVertex`], read-only
         The list of vertices which comprise this edge (start and end)
     is_circle : bool, read-only
@@ -34,22 +38,20 @@ class RhinoBrepEdge(BrepEdge):
 
     """
 
-    def __init__(self, rhino_edge=None):
+    def __init__(self, rhino_trim=None):
         super(RhinoBrepEdge, self).__init__()
         self._edge = None
         self._curve = None
-        self.start_vertex = None
-        self.end_vertex = None
-        if rhino_edge:
-            self._set_edge(rhino_edge)
-
-    def _set_edge(self, native_edge):
-        print("creating Edge object. nativ:{}".format(native_edge))
-        self._edge = native_edge
+        self._start_vertex = None
+        self._end_vertex = None
+        if rhino_trim:
+            self._set_edge(rhino_trim)
+
+    def _set_edge(self, rhino_trim):
+        self._edge = rhino_trim.Edge
         self._curve = self._edge.EdgeCurve
-        # print("creating Edge object. StartVertex:{} EndVertex:{}".format(self._edge.StartVertex.Location, self._edge.EndVertex.Location))
-        # self._curve_start = RhinoBrepVertex(self._edge.StartVertex)
-        # self._curve_end = RhinoBrepVertex(self._edge.EndVertex)
+        self._start_vertex = RhinoBrepVertex(rhino_trim.StartVertex)
+        self._end_vertex = RhinoBrepVertex(rhino_trim.EndVertex)
 
     # ==============================================================================
     # Data
@@ -91,9 +93,9 @@ def data(self, value):
         else:
             self._curve = RhinoNurbsCurve.from_data(value["value"]).rhino_curve
 
-        self.start_vertex, self.end_vertex = RhinoBrepVertex(), RhinoBrepVertex()
-        self.start_vertex._point = Point.from_data(value["points"][0])
-        self.end_vertex._point = Point.from_data(value["points"][1])
+        self._start_vertex, self._end_vertex = RhinoBrepVertex(), RhinoBrepVertex()
+        self._start_vertex._point = Point.from_data(value["points"][0])
+        self._end_vertex._point = Point.from_data(value["points"][1])
 
     # ==============================================================================
     # Properties
@@ -103,13 +105,13 @@ def data(self, value):
     def curve(self):
         return self._curve
 
-    # @property
-    # def start_vertex(self):
-    #     return self._start_vertex
-    #
-    # @property
-    # def end_vertex(self):
-    #     return self._end_vertex
+    @property
+    def start_vertex(self):
+        return self._start_vertex
+
+    @property
+    def end_vertex(self):
+        return self._end_vertex
 
     @property
     def vertices(self):

src/compas_rhino/geometry/brep/face.py

@@ -117,23 +117,9 @@ def _get_surface_geometry(surface):
             raise NotImplementedError("Support for torus surface is not yet implemented!")
         return "nurbs", RhinoNurbsSurface.from_rhino(surface.ToNurbsSurface())
 
-    # @staticmethod
-    # def _make_surface_from_plane_loop(plane, loop):
-    #     # TODO: replace guesswork here with an actual calculation..
-    #     u_degree, v_degree = 1, 1
-    #     u_p_count, v_p_count = 2, 2
-    #     curve_lengths = [edge.curve.GetLength() for edge in loop.edges]
-    #     max_length = max(curve_lengths)
-    #     u_interval, v_interval = (0.0, max_length), (0.0, max_length)
-    #     return RhinoNurbsSurface.from_plane(plane, u_interval, v_interval, u_degree, v_degree, u_p_count, v_p_count)
-
     @staticmethod
     def _make_surface_from_plane_loop(plane, loop):
-        # TODO: replace guesswork here with an actual calculation..
-        c0 = loop.edges[0].start_vertex._point
-        c1 = loop.edges[1].start_vertex._point
-        c2 = loop.edges[2].start_vertex._point
-        c3 = loop.edges[3].start_vertex._point
-        # flipped order flips the normal of the resulting surface!
-        surface = RhinoNurbsSurface.from_corners([c0, c1, c2, c3])
+        # order of corners determines the normal of the resulting surface
+        corners = [loop.edges[i].start_vertex.point for i in range(4)]
+        surface = RhinoNurbsSurface.from_corners(corners)
         return surface

src/compas_rhino/geometry/brep/loop.py

@@ -1,5 +1,4 @@
 from compas.geometry import BrepLoop
-from compas_rhino.conversions import point_to_compas
 
 import Rhino
 
@@ -56,12 +55,7 @@ def __init__(self, rhino_loop=None):
     def _set_loop(self, native_loop):
         self._loop = native_loop
         self._type = int(self._loop.LoopType)
-        self._edges = []
-        for trim in self._loop.Trims:
-            edge = RhinoBrepEdge(trim.Edge)
-            edge.start_vertex = RhinoBrepVertex(trim.StartVertex)
-            edge.end_vertex = RhinoBrepVertex(trim.EndVertex)
-            self._edges.append(edge)
+        self._edges = [RhinoBrepEdge(trim) for trim in self._loop.Trims]
 
     # ==============================================================================
     # Data