Merge pull request #1352 from compas-dev/bugfix/bbox

Bugfix/bbox

Author: tomvanmele

CHANGELOG.md

@@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Changed imports of itertools to `compas.itertools` instead of `compas.utilities`.
 * Updated `compas_rhino.conversions.point_to_compas` to allow for `Rhino.Geometry.Point` as input.
 * Changed `compas.datastructures.Tree.print_hierarchy` to `compas.datastructures.Tree.__str__`.
+* Fixed `compas.geometry.bbox_numpy.minimum_volume_box` to avoid `numpy.linalg.LinAlgError`.
 
 ### Removed
 

src/compas/geometry/bbox_numpy.py

@@ -14,6 +14,7 @@
 from compas.geometry import local_to_world_coordinates_numpy
 from compas.geometry import pca_numpy
 from compas.geometry import world_to_local_coordinates_numpy
+from compas.geometry import length_vector
 from compas.tolerance import TOL
 
 from .bbox import bounding_box
@@ -73,7 +74,7 @@ def oriented_bounding_box_numpy(points, tol=None):
     >>> a = length_vector(subtract_vectors(bbox[1], bbox[0]))
     >>> b = length_vector(subtract_vectors(bbox[3], bbox[0]))
     >>> c = length_vector(subtract_vectors(bbox[4], bbox[0]))
-    >>> close(a * b * c, 30.)
+    >>> close(a * b * c, 30.0)
     True
 
     """
@@ -198,6 +199,8 @@ def minimum_volume_box(points, return_size=False):
     for simplex in hull.simplices:
         a, b, c = points[simplex]
         uvw = local_axes(a, b, c)
+        if not length_vector(uvw[0]) or not length_vector(uvw[1]):
+            continue
         frame = [a, uvw[0], uvw[1]]
         rst = world_to_local_coordinates_numpy(frame, xyz)
         rmin, smin, tmin = amin(rst, axis=0)