Merge pull request #781 from compas-dev/ne_in_ipy

add __ne__ to primitives and transformations

Author: beverlylytle

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 * Fixed bug where mimic joints were considered configurable.
+* Fixed bug where `!=` gave incorrect results in Rhino for some compas objects.
 
 ### Removed
 

src/compas/geometry/primitives/_primitive.py

@@ -18,6 +18,10 @@ class Primitive(Base):
     def __init__(self):
         super(Primitive, self).__init__()
 
+    def __ne__(self, other):
+        # this is not obvious to ironpython
+        return not self.__eq__(other)
+
     @classmethod
     def from_json(cls, filepath):
         """Construct a primitive from structured data contained in a json file.

src/compas/geometry/transformations/transformation.py

@@ -97,6 +97,10 @@ def __eq__(self, other, tol=1e-05):
         except BaseException:
             return False
 
+    def __ne__(self, other):
+        # this is not obvious to ironpython
+        return not self.__eq__(other)
+
     def __repr__(self):
         return "Transformation({})".format(self.matrix)
 

tests/compas/geometry/test_point.py

@@ -13,6 +13,16 @@ def test_point_operators():
     pass
 
 
+def test_point_equality():
+    p1 = Point(1, 1, 1)
+    p2 = Point(1, 1, 1)
+    p3 = Point(0, 0, 0)
+    assert p1 == p2
+    assert not (p1 != p2)
+    assert p1 != p3
+    assert not (p1 == p3)
+
+
 def test_point_inplace_operators():
     pass
 

tests/compas/geometry/test_transformations/test_transformation.py

@@ -135,3 +135,13 @@ def test___str__():
     angle = 0.7854
     R = Rotation.from_axis_and_angle(axes, angle, point=trans)
     assert s == str(R)
+
+
+def test___eq__():
+    i1 = Transformation()
+    i2 = Transformation()
+    t = Translation.from_vector([1, 0, 0])
+    assert i1 == i2
+    assert not (i1 != i2)
+    assert i1 != t
+    assert not (i1 == t)