fix bug related to value of degree in Nurbs Curves

Author: tomvanmele

CHANGELOG.md

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Changed `compas.datastructures.TreeNode` to skip serialising `attributes`, `name` and `children` if being empty. 
 * Changed `compas.datastructures.TreeNode.__repr__` to omit `name` if `None`.
+* Fix bug in `compas_rhino.geometry.NurbsCurve.from_parameters` and `compas_rhino.geometry.NurbsCurve.from_points` related to the value of the parameter `degree`.
 
 ### Removed
 

src/compas_rhino/geometry/curves/__init__.py

@@ -1,19 +1,21 @@
-from .curve import RhinoCurve
+from .curve import RhinoCurve  # noqa: F401
 from .nurbs import RhinoNurbsCurve
 
+from compas.geometry import Curve
+from compas.geometry import NurbsCurve
 from compas.plugins import plugin
 
 
 @plugin(category="factories", requires=["Rhino"])
 def new_curve(cls, *args, **kwargs):
-    curve = object.__new__(RhinoCurve)
+    curve = super(Curve, cls).__new__(cls)
     curve.__init__(*args, **kwargs)
     return curve
 
 
 @plugin(category="factories", requires=["Rhino"])
 def new_nurbscurve(cls, *args, **kwargs):
-    curve = object.__new__(RhinoNurbsCurve)
+    curve = super(NurbsCurve, cls).__new__(cls)
     curve.__init__(*args, **kwargs)
     return curve
 

src/compas_rhino/geometry/curves/nurbs.py

@@ -187,6 +187,7 @@ def from_parameters(cls, points, weights, knots, multiplicities, degree, is_peri
 
         """
         curve = cls()
+        degree = min(degree, len(points) - 1)
         curve.rhino_curve = rhino_curve_from_parameters(points, weights, knots, multiplicities, degree)
         return curve
 
@@ -208,9 +209,10 @@ def from_points(cls, points, degree=3, is_periodic=False):
         :class:`compas_rhino.geometry.RhinoNurbsCurve`
 
         """
-        points[:] = [point_to_rhino(point) for point in points]
         curve = cls()
-        curve.rhino_curve = Rhino.Geometry.NurbsCurve.Create(is_periodic, degree, points)
+        degree = min(degree, len(points) - 1)
+        rhino_curve = Rhino.Geometry.NurbsCurve.Create(is_periodic, degree, [point_to_rhino(point) for point in points])
+        curve.rhino_curve = rhino_curve
         return curve
 
     @classmethod