Merge pull request #1090 from compas-dev/symlinks

Use a junction instead of a symbolic link

Author: tomvanmele

CHANGELOG.md

@@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+* Changed `compas._os._polyfill_symlinks` to use junction (/J) instead of symbolic link (/D).
+
 ### Removed
 
 

src/compas/_os.py

@@ -316,7 +316,7 @@ def _polyfill_symlinks(symlinks, raise_on_error):
         mklink_cmd.write("SET /A symlink_result=0\n")
         mklink_cmd.write("ECHO ret=%symlink_result%\n")
         for i, (source, link_name) in enumerate(symlinks):
-            dir_symlink_arg = "/D" if os.path.isdir(source) else ""
+            dir_symlink_arg = "/J" if os.path.isdir(source) else ""
             mklink_cmd.write("mklink {} {}\n".format(dir_symlink_arg, subprocess.list2cmdline([link_name, source])))
             mklink_cmd.write("IF %ERRORLEVEL% EQU 0 SET /A symlink_result += {} \n".format(2**i))
 

src/compas_ghpython/components/__init__.py

@@ -26,8 +26,8 @@
 import glob
 import os
 
-from compas._os import create_symlinks
 from compas._os import remove_symlinks
+from compas._os import copy as _copy
 from compas_ghpython import get_grasshopper_userobjects_path
 from compas_rhino import _check_rhino_version
 import compas_rhino
@@ -75,7 +75,14 @@ def install_userobjects(source):
     remove_symlinks(symlinks_to_remove)
 
     # And the create new ones
-    created = create_symlinks(symlinks_to_add)
+    created = []
+    for src, dst in symlinks_to_add:
+        try:
+            _copy(src, dst)
+        except Exception:
+            created.append(False)
+        else:
+            created.append(True)
 
     return list(zip(symlinks_to_add, created))