simplified call to RhinoNurbsSurface.from_frame

Author: chenkasirer

src/compas_rhino/geometry/brep/face.py

@@ -139,9 +139,10 @@ def _get_surface_geometry(surface):
 
     @staticmethod
     def _make_surface_from_data(surface_type, surface_data, uv_domain):
+        u_domain, v_domain = uv_domain
         if surface_type == "plane":
             frame = Frame.from_data(surface_data)
-            surface = RhinoNurbsSurface.from_frame(frame, uv_domain[0], uv_domain[1], (1, 1), (2, 2))
+            surface = RhinoNurbsSurface.from_frame(frame, u_domain, v_domain)
         elif surface_type == "sphere":
             surface = RhinoNurbsSurface.from_sphere(Sphere.from_data(surface_data))
         elif surface_type == "cylinder":
@@ -150,6 +151,6 @@ def _make_surface_from_data(surface_type, surface_data, uv_domain):
             surface = RhinoNurbsSurface.from_data(surface_data)
         elif surface_type == "torus":
             raise NotImplementedError("Support for torus surface is not yet implemented!")
-        surface.rhino_surface.SetDomain(0, Interval(*uv_domain[0]))
-        surface.rhino_surface.SetDomain(1, Interval(*uv_domain[1]))
+        surface.rhino_surface.SetDomain(0, Interval(*u_domain))
+        surface.rhino_surface.SetDomain(1, Interval(*v_domain))
         return surface

src/compas_rhino/geometry/surfaces/surface.py

@@ -189,7 +189,7 @@ def from_plane(cls, plane, box):
         return cls.from_rhino(rhino_surface)
 
     @classmethod
-    def from_frame(cls, frame, u_interval, v_interval, uv_degrees, uv_point_counts):
+    def from_frame(cls, frame, u_interval, v_interval, uv_degrees=(1, 1), uv_point_counts=(2, 2)):
         """Creates a NURBS surface from a frame and parametric domain information.
 
         Parameters
@@ -202,9 +202,9 @@ def from_frame(cls, frame, u_interval, v_interval, uv_degrees, uv_point_counts):
         v_interval : tuple(float, float)
             The parametric domain of the V parameter. v_interval[0] => v_interval[1].
         uv_degrees : tuple(int, int)
-            Degree of U and V parameters. uv_degree[0] => degree_u, uv_degree[1] => degree_v
+            Degree of U and V parameters. Default is 1 in both directions for a simple planar surface.
         uv_point_counts :
-            Number of control points in each parameter. [0] => cp_count_u, [1] => cp_count_v
+            Number of control points in each parameter. Default is 2 in both directions for a simple planar surface.
 
         Returns
         -------