Skip to content

Commit bddb575

Browse files
committed
brep_x -> breps_x, completed docstrings
1 parent 0f2a5b5 commit bddb575

File tree

1 file changed

+26
-20
lines changed
  • src/compas_rhino/geometry/brep

1 file changed

+26
-20
lines changed

src/compas_rhino/geometry/brep/brep.py

Lines changed: 26 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -236,21 +236,23 @@ def from_boolean_difference(cls, breps_a, breps_b):
236236
Parameters
237237
----------
238238
brep_a : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
239+
One or more Breps from which to substract.
239240
brep_b : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
241+
One or more Breps to substract.
240242
241243
Returns
242244
-------
243245
list(:class:`~compas_rhino.geometry.RhinoBrep`)
244246
list of one or more resulting Breps.
245247
246248
"""
247-
if not isinstance(brep_a, list):
248-
brep_a = [brep_a]
249-
if not isinstance(brep_b, list):
250-
brep_b = [brep_b]
249+
if not isinstance(breps_a, list):
250+
breps_a = [breps_a]
251+
if not isinstance(breps_b, list):
252+
breps_b = [breps_b]
251253
resulting_breps = Rhino.Geometry.Brep.CreateBooleanDifference(
252-
[b.native_brep for b in brep_a],
253-
[b.native_brep for b in brep_b],
254+
[b.native_brep for b in breps_a],
255+
[b.native_brep for b in breps_b],
254256
TOLERANCE
255257
)
256258
return [RhinoBrep.from_brep(brep) for brep in resulting_breps]
@@ -261,45 +263,49 @@ def from_boolean_union(cls, breps_a, breps_b):
261263
262264
Parameters
263265
----------
264-
brep_a : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
265-
brep_b : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
266+
breps_a : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
267+
One of more breps to join.
268+
breps_b : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
269+
Another one of more breps to join.
266270
267271
Returns
268272
-------
269273
list(:class:`~compas_rhino.geometry.RhinoBrep`)
270274
list of one or more resulting Breps.
271275
272276
"""
273-
if not isinstance(brep_a, list):
274-
brep_a = [brep_a]
275-
if not isinstance(brep_b, list):
276-
brep_b = [brep_b]
277+
if not isinstance(breps_a, list):
278+
breps_a = [breps_a]
279+
if not isinstance(breps_b, list):
280+
breps_b = [breps_b]
277281

278-
resulting_breps = Rhino.Geometry.Brep.CreateBooleanUnion([b.native_brep for b in brep_a + brep_b], TOLERANCE)
282+
resulting_breps = Rhino.Geometry.Brep.CreateBooleanUnion([b.native_brep for b in breps_a + breps_b], TOLERANCE)
279283
return [RhinoBrep.from_brep(brep) for brep in resulting_breps]
280284

281285
@classmethod
282-
def from_boolean_intersection(cls, brep_a, brep_b):
286+
def from_boolean_intersection(cls, breps_a, breps_b):
283287
"""Construct a Brep from the boolean intersection of two groups of Breps.
284288
285289
Parameters
286290
----------
287291
brep_a : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
292+
One or more Breps to instrsect.
288293
brep_b : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
294+
Another one or more Breps to intersect.
289295
290296
Returns
291297
-------
292298
list(:class:`~compas_rhino.geometry.RhinoBrep`)
293299
list of one or more resulting Breps.
294300
295301
"""
296-
if not isinstance(brep_a, list):
297-
brep_a = [brep_a]
298-
if not isinstance(brep_b, list):
299-
brep_b = [brep_b]
302+
if not isinstance(breps_a, list):
303+
breps_a = [breps_a]
304+
if not isinstance(breps_b, list):
305+
breps_b = [breps_b]
300306
resulting_breps = Rhino.Geometry.Brep.CreateBooleanIntersection(
301-
[b.native_brep for b in brep_a],
302-
[b.native_brep for b in brep_b],
307+
[b.native_brep for b in breps_a],
308+
[b.native_brep for b in breps_b],
303309
TOLERANCE
304310
)
305311
return [RhinoBrep.from_brep(brep) for brep in resulting_breps]

0 commit comments

Comments
 (0)