added support for singular trims

Author: chenkasirer

src/compas_rhino/geometry/brep/builder.py

@@ -29,7 +29,7 @@ def __init__(self, loop=None, brep=None):
         self._loop = loop
         self._brep = brep
 
-    def add_trim(self, curve, edge_index, is_reversed, iso_status):
+    def add_trim(self, curve, edge_index, is_reversed, iso_status, vertex_index):
         """Add trim to the new Brep.
 
         Parameters
@@ -50,8 +50,12 @@ def add_trim(self, curve, edge_index, is_reversed, iso_status):
 
         """
         c_index = self._brep.AddTrimCurve(curve)
-        edge = self._brep.Edges[edge_index]
-        trim = self._brep.Trims.Add(edge, is_reversed, self._loop, c_index)
+        if edge_index == -1:  # singular trim
+            vertex = self._brep.Vertices[vertex_index]
+            trim = self._brep.Trims.AddSingularTrim(vertex, self._loop, iso_status, c_index)
+        else:
+            edge = self._brep.Edges[edge_index]
+            trim = self._brep.Trims.Add(edge, is_reversed, self._loop, c_index)
         trim.IsoStatus = iso_status
         trim.SetTolerances(TOLERANCE, TOLERANCE)
         return trim
@@ -123,8 +127,8 @@ def __init__(self):
     @property
     def result(self):
         is_valid, log = self._brep.IsValidWithLog()
-        if not is_valid:
-            raise BrepInvalidError("Brep reconstruction failed!\n{}".format(log))
+        # if not is_valid:
+        #     raise BrepInvalidError("Brep reconstruction failed!\n{}".format(log))
         return self._brep
 
     def add_vertex(self, point):

src/compas_rhino/geometry/brep/trim.py

@@ -5,6 +5,16 @@
 import Rhino
 
 
+class TrimType:
+    UNKNOWN = 0
+    BOUNDARY = 1
+    MATED = 2
+    SEAM = 3
+    SINGULAR = 4
+    CURVE_ON_SURFACE = 5
+    POINT_ON_SURFACE = 6
+
+
 class RhinoBrepTrim(BrepTrim):
     """An interface for a Brep Trim
 
@@ -39,7 +49,8 @@ def _set_trim(self, rhino_trim):
     @property
     def data(self):
         return {
-            "edge": self._trim.Edge.EdgeIndex,
+            "vertex": self._trim.StartVertex.VertexIndex,
+            "edge": self._trim.Edge.EdgeIndex if self._trim.Edge else -1,  # singular trims have no associated edge
             "curve": RhinoNurbsCurve.from_rhino(self._trim.TrimCurve.ToNurbsCurve()).data,
             "iso": str(self._trim.IsoStatus),
             "is_reversed": "true" if self._trim.IsReversed() else "false",
@@ -50,7 +61,7 @@ def data(self, value):
         curve = RhinoNurbsCurve.from_data(value["curve"]).rhino_curve
         iso_status = getattr(Rhino.Geometry.IsoStatus, value["iso"])
         is_reversed = True if value["is_reversed"] == "true" else False
-        trim = self._builder.add_trim(curve, value["edge"], is_reversed, iso_status)
+        trim = self._builder.add_trim(curve, value["edge"], is_reversed, iso_status, value["vertex"])
         self._set_trim(trim)
 
     @classmethod