Skip to content

Commit d3306c0

Browse files
authored
Merge pull request #1390 from robin-oval/fix/mesh_face_circle
Fix Mesh.face_circle
2 parents 975dc97 + e0dc716 commit d3306c0

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1616

1717
* Fixed args for `SceneObject` on Grasshopper `Draw` component.
1818
* Replaced use of `Rhino.Geometry.VertexColors.SetColors` with a for loop and `SetColor` in `compas_ghpyton` since the former requires a `System.Array`.
19+
* Fixed `Mesh.face_circle`.
1920

2021
### Removed
2122

src/compas/datastructures/mesh/mesh.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4542,7 +4542,7 @@ def face_circle(self, face):
45424542
from compas.geometry import bestfit_circle_numpy
45434543

45444544
point, normal, radius = bestfit_circle_numpy(self.face_coordinates(face))
4545-
return Circle((point, normal), radius)
4545+
return Circle.from_plane_and_radius(Plane(point, normal), radius)
45464546

45474547
def face_frame(self, face):
45484548
"""The frame of a face.

0 commit comments

Comments
 (0)