Merge pull request #1414 from papachap/feature-brep-fillet-edges

add implementation of fillet edges to brep

Author: chenkasirer

AUTHORS.md

@@ -39,4 +39,5 @@
 - Katerina Toumpektsi <<[email protected]>> [@katarametin](https://github.com/katarametin)
 - Joelle Baehr-Bruyere <<[email protected]>> [@baehrjo](https://github.com/baehrjo)
 - Adam Anouar <<[email protected]>> [@AdamAnouar](https://github.com/AdamAnouar)
-- Joseph Kenny <<[email protected]>> [@jckenny59](https://github.com/jckenny59)
+- Joseph Kenny <<[email protected]>> [@jckenny59](https://github.com/jckenny59)
+- Panayiotis Papacharalambous <<[email protected]>> [@papachap](https://github.com/papachap)

CHANGELOG.md

@@ -9,8 +9,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+* Added implementation of `RhinoBrep.fillet()` and `RhinoBrep.filleted()` to `compas_rhino`.
+
 ### Changed
 
+* Fixed `native_edge` property of `RhinoBrepEdge`.
+
 ### Removed
 
 

src/compas_rhino/geometry/brep/brep.py

@@ -6,6 +6,7 @@
 
 from compas.geometry import Brep
 from compas.geometry import BrepError
+from compas.geometry import BrepFilletError
 from compas.geometry import BrepTrimmingError
 from compas.geometry import Frame
 from compas.geometry import Plane
@@ -583,3 +584,56 @@ def split(self, cutter):
         """
         resulting_breps = self._brep.Split(cutter.native_brep, TOL.absolute)
         return [RhinoBrep.from_native(brep) for brep in resulting_breps]
+
+    def fillet(self, radius, edges=None):
+        """Fillet edges of the Brep.
+
+        Parameters
+        ----------
+        radius : float
+            The radius of the fillet.
+        edges : list(:class:`compas_rhino.geometry.RhinoBrepEdge`)
+            The edges to fillet.
+
+        Raises
+        -------
+        BrepFilletingError
+            If the fillet operation fails.
+
+        """
+        resulting_breps = self.filleted(radius, edges)
+        self._brep = resulting_breps.native_brep
+
+    def filleted(self, radius, edges=None):
+        """Returns a filleted copy of the Brep.
+
+        Parameters
+        ----------
+        radius : float
+            The radius of the fillet.
+        edges : list(:class:`compas_rhino.geometry.RhinoBrepEdge`)
+            List of edges to exclude from the operation. When None all edges are included.
+
+        Returns
+        -------
+        :class:`compas_rhino.geometry.RhinoBrep`
+            The resulting Brep.
+
+        Raises
+        -------
+        BrepFilletingError
+            If the fillet operation fails.
+
+        """
+        all_edge_indices = set(edge.native_edge.EdgeIndex for edge in self.edges)
+        excluded_indices = set(edge.native_edge.EdgeIndex for edge in edges or [])
+
+        edge_indices = all_edge_indices - excluded_indices
+        radii = [radius] * len(edge_indices)
+        blend = Rhino.Geometry.BlendType.Fillet
+        rail = Rhino.Geometry.RailType.DistanceFromEdge
+
+        resulting_breps = Rhino.Geometry.Brep.CreateFilletEdges(self._brep, edge_indices, radii, radii, blend, rail, TOL.absolute)
+        if not resulting_breps:
+            raise BrepFilletError("Fillet operation ended with no result")
+        return RhinoBrep.from_native(resulting_breps[0])

src/compas_rhino/geometry/brep/edge.py

@@ -115,7 +115,7 @@ def curve(self):
 
     @property
     def native_edge(self):
-        return self._native_edge
+        return self._edge
 
     @native_edge.setter
     def native_edge(self, value):