Merge pull request #1064 from compas-dev/brep_boolean_ops

Brep boolean ops

Author: chenkasirer

CHANGELOG.md

@@ -15,11 +15,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Added pluggable `Brep` support with `compas.geometry.brep`.
 * Added Rhino `Brep` plugin in `compas_rhino.geometry.brep`.
+* Added boolean operations to the `compas_rhino` `Brep` backend.
+* Added boolean operation operator overloads in `compas.geometry.Brep`
 
 ### Changed
 * Based all gltf data classes on `BaseGLTFDataClass`
 
 * Fixed `Color.__get___` AttributeError.
+* Fixed `cylinder_to_rhino` conversion to match `compas.geometry.Cylinder` location.
 
 ### Removed
 

src/compas/geometry/brep/brep.py

@@ -607,6 +607,63 @@ def from_boolean_union(cls, brep_a, brep_b):
         """
         raise NotImplementedError
 
+    def __sub__(self, other):
+        """Compute the boolean difference using the "-" operator of this shape and another.
+
+        Parameters
+        ----------
+        other : :class:`~compas.geometry.Brep`
+            The other Brep to create a union with.
+
+        Returns
+        -------
+        :class:`~compas.geometry.Brep`
+            The Brep resulting from the difference operation.
+
+        """
+        results = type(self).from_boolean_difference(self, other)
+        if isinstance(results, list):
+            results = results[0]
+        return results
+
+    def __and__(self, other):
+        """Compute the boolean intersection using the "&" operator of this shape and another.
+
+        Parameters
+        ----------
+        other : :class:`~compas.geometry.Brep`
+            The other Brep to create a union with.
+
+        Returns
+        -------
+        :class:`~compas.geometry.Brep`
+            The Brep resulting from the intersection operation.
+
+        """
+        results = type(self).from_boolean_intersection(self, other)
+        if isinstance(results, list):
+            results = results[0]
+        return results
+
+    def __add__(self, other):
+        """Compute the boolean union using the "+" operator of this Brep and another.
+
+        Parameters
+        ----------
+        other : :class:`~compas.geometry.Brep`
+            The other Brep to create a union with.
+
+        Returns
+        -------
+        :class:`~compas.geometry.Brep`
+            The Brep resulting from the union operation.
+
+        """
+        results = type(self).from_boolean_union(self, other)
+        if isinstance(results, list):
+            results = results[0]
+        return results
+
     # ==============================================================================
     # Converters
     # ==============================================================================

src/compas_rhino/conversions/_shapes.py

@@ -158,4 +158,7 @@ def cylinder_to_rhino(cylinder):
     :rhino:`Rhino.Geometry.Cylinder`
 
     """
-    return RhinoCylinder(circle_to_rhino(cylinder.circle), cylinder.height)
+    circle = cylinder.circle.copy()
+    height = cylinder.height
+    circle.plane.point += circle.plane.normal * (-0.5 * height)
+    return RhinoCylinder(circle_to_rhino(circle), cylinder.height)

src/compas_rhino/geometry/brep/__init__.py

@@ -36,3 +36,8 @@ def from_brep(*args, **kwargs):
 @plugin(category="factories", requires=["Rhino"])
 def from_box(*args, **kwargs):
     return RhinoBrep.from_box(*args, **kwargs)
+
+
+@plugin(category="factories", requires=["Rhino"])
+def from_cylinder(*args, **kwargs):
+    return RhinoBrep.from_cylinder(*args, **kwargs)

src/compas_rhino/geometry/brep/brep.py

@@ -8,6 +8,7 @@
 from compas_rhino.conversions import point_to_rhino
 from compas_rhino.conversions import xform_to_rhino
 from compas_rhino.conversions import frame_to_rhino
+from compas_rhino.conversions import cylinder_to_rhino
 
 import Rhino
 
@@ -166,6 +167,23 @@ def from_box(cls, box):
         rhino_box = box_to_rhino(box)
         return cls.from_brep(rhino_box.ToBrep())
 
+    @classmethod
+    def from_cylinder(cls, cylinder):
+        """Create a RhinoBrep from a box.
+
+        Parameters
+        ----------
+        box : :class:`~compas.geometry.Box`
+            The box geometry of the brep.
+
+        Returns
+        -------
+        :class:`~compas_rhino.geometry.RhinoBrep`
+
+        """
+        rhino_cylinder = cylinder_to_rhino(cylinder)
+        return cls.from_brep(rhino_cylinder.ToBrep(True, True))
+
     # ==============================================================================
     # Methods
     # ==============================================================================
@@ -211,6 +229,87 @@ def trim(self, trimming_plane, tolerance=TOLERANCE):
 
         self._brep = results[0]
 
+    @classmethod
+    def from_boolean_difference(cls, breps_a, breps_b):
+        """Construct a Brep from the boolean difference of two groups of Breps.
+
+        Parameters
+        ----------
+        breps_a : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            One or more Breps from which to substract.
+        breps_b : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            One or more Breps to substract.
+
+        Returns
+        -------
+        list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            list of one or more resulting Breps.
+
+        """
+        if not isinstance(breps_a, list):
+            breps_a = [breps_a]
+        if not isinstance(breps_b, list):
+            breps_b = [breps_b]
+        resulting_breps = Rhino.Geometry.Brep.CreateBooleanDifference(
+            [b.native_brep for b in breps_a],
+            [b.native_brep for b in breps_b],
+            TOLERANCE
+        )
+        return [RhinoBrep.from_brep(brep) for brep in resulting_breps]
+
+    @classmethod
+    def from_boolean_union(cls, breps_a, breps_b):
+        """Construct a Brep from the boolean union of two groups of Breps.
+
+        Parameters
+        ----------
+        breps_a : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            One of more breps to join.
+        breps_b : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            Another one of more breps to join.
+
+        Returns
+        -------
+        list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            list of one or more resulting Breps.
+
+        """
+        if not isinstance(breps_a, list):
+            breps_a = [breps_a]
+        if not isinstance(breps_b, list):
+            breps_b = [breps_b]
+
+        resulting_breps = Rhino.Geometry.Brep.CreateBooleanUnion([b.native_brep for b in breps_a + breps_b], TOLERANCE)
+        return [RhinoBrep.from_brep(brep) for brep in resulting_breps]
+
+    @classmethod
+    def from_boolean_intersection(cls, breps_a, breps_b):
+        """Construct a Brep from the boolean intersection of two groups of Breps.
+
+        Parameters
+        ----------
+        breps_a : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            One or more Breps to instrsect.
+        breps_b : :class:`~compas_rhino.geometry.RhinoBrep` or list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            Another one or more Breps to intersect.
+
+        Returns
+        -------
+        list(:class:`~compas_rhino.geometry.RhinoBrep`)
+            list of one or more resulting Breps.
+
+        """
+        if not isinstance(breps_a, list):
+            breps_a = [breps_a]
+        if not isinstance(breps_b, list):
+            breps_b = [breps_b]
+        resulting_breps = Rhino.Geometry.Brep.CreateBooleanIntersection(
+            [b.native_brep for b in breps_a],
+            [b.native_brep for b in breps_b],
+            TOLERANCE
+        )
+        return [RhinoBrep.from_brep(brep) for brep in resulting_breps]
+
     # ==============================================================================
     # Other Methods
     # ==============================================================================

src/compas_rhino/geometry/brep/face.py

@@ -47,7 +47,9 @@ def _set_face(self, native_face):
     def data(self):
         boundary = self._loops[0].data
         holes = [loop.data for loop in self._loops[1:]]
-        return {"boundary": boundary, "surface": self._surface.data, "holes": holes}
+        surface = {"type": "nurbs"}
+        surface.update(self.surface.data)
+        return {"boundary": boundary, "surface": surface, "holes": holes}
 
     @data.setter
     def data(self, value):