Merge pull request #857 from yck011522/main

Changes to draw_breps() to fix #854 #855

Author: tomvanmele

CHANGELOG.md

@@ -88,6 +88,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Changed directory where ghuser components are installed.
 * Added ghuser components directory to those removed by the `clean` task.
 * Clean up the ghuser directory before building ghuser components.
+* Exposed function `draw_breps` in `compas_rhino.utilities`; example added.
+* Added `join` flag to function `draw_breps` in `compas_rhino.utilities`
 * Fixed bug in `compas.geometry.distance.closest_point_on_segment_xy`.
 * Fixed bug in Rhino implementations of `trimesh` curvature functions.
 
@@ -281,9 +283,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Fixed bug regarding a repeated call to `RobotModel.add_joint`.
 * Fixed bug in `compas_blender.RobotModelArtist.update`.
 * Fixed bug in `compas.datastructures.mesh_slice_plane`.
-* Fixed bug where initialising a `compas_blender.artists.Robotmodelartist` would create a new collection for each mesh and then also not put the mesh iton the created collection. 
-* Changed the initialisation of `compas_blender.artists.Robotmodelartist` to include a `collection`-parameter instead of a `layer`-parameter to be more consistent with Blender's nomenclature. 
-* Used a utility function from `compas_blender.utilities` to create the collection if none exists instead of using a new call to a bpy-method. 
+* Fixed bug where initialising a `compas_blender.artists.Robotmodelartist` would create a new collection for each mesh and then also not put the mesh iton the created collection.
+* Changed the initialisation of `compas_blender.artists.Robotmodelartist` to include a `collection`-parameter instead of a `layer`-parameter to be more consistent with Blender's nomenclature.
+* Used a utility function from `compas_blender.utilities` to create the collection if none exists instead of using a new call to a bpy-method.
 
 ### Removed
 

src/compas_rhino/utilities/__init__.py

@@ -179,6 +179,7 @@
     draw_lines,
     draw_geodesics,
     draw_polylines,
+    draw_breps,
     draw_faces,
     draw_cylinders,
     draw_pipes,
@@ -275,6 +276,7 @@
     'draw_lines',
     'draw_geodesics',
     'draw_polylines',
+    'draw_breps',
     'draw_faces',
     'draw_cylinders',
     'draw_pipes',

src/compas_rhino/utilities/drawing.py

@@ -72,6 +72,7 @@
     'draw_lines',
     'draw_geodesics',
     'draw_polylines',
+    'draw_breps',
     'draw_faces',
     'draw_cylinders',
     'draw_pipes',
@@ -421,7 +422,7 @@ def draw_polylines(polylines, **kwargs):
 
 
 @wrap_drawfunc
-def draw_breps(faces, srf=None, u=10, v=10, trim=True, tangency=True, spacing=0.1, flex=1.0, pull=1.0, **kwargs):
+def draw_breps(faces, srf=None, u=10, v=10, trim=True, tangency=True, spacing=0.1, flex=1.0, pull=1.0, join=False, **kwargs):
     """Draw polygonal faces as Breps, and optionally set individual name, color,
     and layer properties.
 
@@ -443,6 +444,8 @@ def draw_breps(faces, srf=None, u=10, v=10, trim=True, tangency=True, spacing=0.
     spacing : float, optional
     flex : float, optional
     pull : float, optional
+    join : bool, optional
+        Join the individual faces as polysurfaces. Default is False.
 
     Returns
     -------
@@ -461,8 +464,31 @@ def draw_breps(faces, srf=None, u=10, v=10, trim=True, tangency=True, spacing=0.
             Optional('layer', default=None): str,
         })
 
+    Examples
+    --------
+    Using a compas Mesh as an example:
+
+    >>> from compas.datastructures import Mesh
+    >>> from compas.geometry import Box, Frame
+    >>> from compas_rhino.utilities import draw_breps
+    >>> box = Box(Frame.worldXY(), 1.0, 2.0, 3.0)
+    >>> mesh = Mesh.from_shape(box)
+
+    Draw convert each mesh face to brep dict schema:
+
+    >>> vertices = [mesh.vertex_attributes(vertex, 'xyz') for vertex in mesh.vertices()]
+    >>> breps = []
+    >>> for face in mesh.faces():
+    >>>     face = {'points' : [vertices[vertex] for vertex in mesh.face_vertices(face)]}
+    >>>     face['points'].append(face['points'][0])
+    >>>     breps.append(face)
+
+    Draw brep faces as one joined brep.
+
+    >>> guids = draw_breps(breps, join=True)
+
     """
-    guids = []
+    breps = []
     for f in iter(faces):
         points = f['points']
         name = f.get('name', '')
@@ -486,8 +512,14 @@ def draw_breps(faces, srf=None, u=10, v=10, trim=True, tangency=True, spacing=0.
                                                TOL)
         else:
             brep = Brep.CreatePatch(geo, u, v, TOL)
-        if not brep:
-            continue
+        if brep:
+            breps.append(brep)
+
+    if join:
+        breps = Brep.JoinBreps(breps, TOL)
+
+    guids = []
+    for brep in breps:
         guid = add_brep(brep)
         if not guid:
             continue