Merge pull request #1426 from compas-dev/rectangle_xy

Rectangle xy

Author: tomvanmele

CHANGELOG.md

@@ -13,10 +13,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+* Fixed unexpected behavior in `compas.geometry.bbox_numpy.minimum_area_rectangle_xy`.
 * Changed `requirements.txt` to allow `numpy>=2`.
 * Fixed bug in `compas.geometry.Polygon.points` setter by removing duplicate points if they exist.
 * Fixed bug in `compas.geometry.Polygon.plane` by aligning the normal of the bestfit plane with the approximate normal of the polygon faces.
-* Changed the order of face vertices in `compas.geometry.Surface.to_vertices_and_faces` to a counter clockwise cycling direction and outward facing normals for curved surfaces.
+* Changed the order of face vertices in `compas.geometry.Surface.to_vertices_and_faces` to a counter clockwise cycling direction and outward facing normals for curved surfaces.>>>>>>> main
 
 ### Removed
 

src/compas/geometry/bbox_numpy.py

@@ -250,11 +250,10 @@ def minimum_area_rectangle_xy(points, return_size=False):
     """
     boxes = []
 
-    n = len(points)
     points = points[:, :2]
     hull = ConvexHull(points)
     xy = points[hull.vertices, :2]
-    mean = sum(xy, axis=0) / n
+    hull_centroid = sum(xy, axis=0) / len(xy)
 
     for simplex in hull.simplices:
         p0 = points[simplex[0]]
@@ -288,7 +287,7 @@ def minimum_area_rectangle_xy(points, return_size=False):
         a = w * h
 
         # other box corners
-        if dot(t, mean - p0) < 0:
+        if dot(t, hull_centroid - p0) < 0:
             b3 = b0 - h * tu
             b2 = b1 - h * tu
         else: