fix: pass params by const ref, avoid copies

Author: jf---

src/compas_cgal/polylines.py

@@ -1,6 +1,5 @@
 """Polyline utilities using CGAL."""
 
-from typing import TYPE_CHECKING
 from typing import List
 from typing import Union
 
@@ -11,8 +10,7 @@
 from compas_cgal._polylines import closest_points_on_polyline as _closest_points
 from compas_cgal._polylines import simplify_polylines as _simplify
 
-if TYPE_CHECKING:
-    PointsList = Union[List[List[float]], NDArray]
+PointsList = Union[List[List[float]], NDArray]
 
 
 __all__ = ["simplify_polylines", "simplify_polyline", "closest_points_on_polyline"]

src/polylines.cpp

@@ -78,7 +78,7 @@ static void rdp_simplify(
 
 std::vector<compas::RowMatrixXd>
 pmp_simplify_polylines(
-    std::vector<compas::RowMatrixXd> polylines,
+    const std::vector<compas::RowMatrixXd>& polylines,
     double threshold)
 {
     std::vector<compas::RowMatrixXd> results;
@@ -127,8 +127,8 @@ pmp_simplify_polylines(
 
 compas::RowMatrixXd
 pmp_closest_points_on_polyline(
-    compas::RowMatrixXd query_points,
-    compas::RowMatrixXd polyline)
+    const compas::RowMatrixXd& query_points,
+    const compas::RowMatrixXd& polyline)
 {
     int n_queries = query_points.rows();
     int q_cols = query_points.cols();

src/polylines.h

@@ -19,7 +19,7 @@
  */
 std::vector<compas::RowMatrixXd>
 pmp_simplify_polylines(
-    std::vector<compas::RowMatrixXd> polylines,
+    const std::vector<compas::RowMatrixXd>& polylines,
     double threshold);
 
 /**
@@ -31,5 +31,5 @@ pmp_simplify_polylines(
  */
 compas::RowMatrixXd
 pmp_closest_points_on_polyline(
-    compas::RowMatrixXd query_points,
-    compas::RowMatrixXd polyline);
+    const compas::RowMatrixXd& query_points,
+    const compas::RowMatrixXd& polyline);