Skip to content

Commit 3aa7bfa

Browse files
committed
Typo in meth name and corrected name of Transformation constructor
1 parent 22830d7 commit 3aa7bfa

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/compas_fab/artists/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def scale(self, factor):
171171
self.robot.scale(factor) # scale the model
172172

173173
relative_factor = factor / self.scale_factor # relative scaling factor
174-
transformation = Scale.from_factor([relative_factor] * 3)
174+
transformation = Scale.from_factors([relative_factor] * 3)
175175
self.scale_link(self.robot.root, transformation)
176176
self.scale_factor = factor
177177

src/compas_fab/robots/constraints.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def from_mesh(cls, mesh):
9191
return cls(cls.MESH, mesh)
9292

9393
def scale(self, scale_factor):
94-
S = Scale.from_factor([scale_factor] * 3)
94+
S = Scale.from_factors([scale_factor] * 3)
9595
self.transform(S)
9696

9797
def transform(self, transformation):

src/compas_fab/robots/robot.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ def transformation_RCF_WCF(self, group=None):
568568
569569
"""
570570
base_frame = self.get_base_frame(group)
571-
return Transformation.change_basis(base_frame, Frame.worldXY())
571+
return Transformation.change_of_basis(base_frame, Frame.worldXY())
572572

573573
def transformation_WCF_RCF(self, group=None):
574574
"""Returns the transformation from the world coordinate system (WCF) to the robot's coordinate system (RCF).
@@ -584,7 +584,7 @@ def transformation_WCF_RCF(self, group=None):
584584
585585
"""
586586
base_frame = self.get_base_frame(group)
587-
return Transformation.change_basis(Frame.worldXY(), base_frame)
587+
return Transformation.change_of_basis(Frame.worldXY(), base_frame)
588588

589589
def set_RCF(self, robot_coordinate_frame, group=None):
590590
"""Moves the origin frame of the robot to the robot_coordinate_frame.

0 commit comments

Comments
 (0)