linear deflection

Author: Licini

CHANGELOG.md

@@ -9,10 +9,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+* Added `linear_deflection` parameter to `Model.show()`, defaulting to 100 for faster BRep tesselation.
+
 ### Changed
 
 ### Removed
 
+* Removed `Model.update_linear_deflection()`
 
 ## [1.6.0] 2025-06-04
 

src/compas_ifc/brep/ifcbrepobject.py

@@ -1,18 +1,17 @@
 try:
     import numpy as np
     from compas.colors import Color
-    from compas.tolerance import TOL
     from compas_occ.brep import OCCBrep
     from compas_viewer.scene.brepobject import BRepObject
 
     class IFCBrepObject(BRepObject):
-        def __init__(self, shellcolors=None, **kwargs):
+        def __init__(self, shellcolors=None, linear_deflection=100, **kwargs):
             brep = kwargs["item"]
             brep.simplify()
             brep.heal()
 
             super().__init__(**kwargs)
-            self.shells = [shell.to_tesselation(TOL.lineardeflection)[0] for shell in self.brep.shells]
+            self.shells = [shell.to_tesselation(linear_deflection)[0] for shell in self.brep.shells]
             self.shellcolors = shellcolors or [self.facecolor.rgba for _ in self.shells]
             self._bounding_box_center = None
 

src/compas_ifc/model.py

@@ -9,7 +9,6 @@
 from compas.geometry import Frame
 from compas.geometry import Geometry
 from compas.geometry import Transformation
-from compas.tolerance import TOL
 
 from compas_ifc.file import IFCFile
 
@@ -74,8 +73,6 @@ def __init__(self, filepath: str = None, schema: str = "IFC4", use_occ: bool = F
 
         """
         self.file = IFCFile(self, filepath=filepath, schema=schema, use_occ=use_occ, load_geometries=load_geometries, verbose=verbose, extensions=extensions)
-        if filepath:
-            self.update_linear_deflection()
 
     @property
     def schema(self) -> "ifcopenshell.ifcopenshell_wrapper.schema_definition":
@@ -257,13 +254,16 @@ def export(self, path: str, entities: list["Base"] = [], as_snippet: bool = Fals
         """
         self.file.export(path, entities=entities, as_snippet=as_snippet, export_materials=export_materials, export_properties=export_properties, export_styles=export_styles)
 
-    def show(self, entity: "Base" = None):
+    def show(self, entity: "Base" = None, linear_deflection: float = 100):
         """Show the IFC file in a viewer, either the entire project or a single entity.
 
         Parameters
         ----------
         entity : :class:`compas_ifc.entities.base.Base`
             The entity to show. If None, the entire project will be shown.
+        linear_deflection : float
+            The linear deflection to use for the tesselation of BREP geometries.
+            Should be adjusted based on the size of the model.
         """
         try:
             from compas_viewer import Viewer
@@ -274,6 +274,7 @@ def show(self, entity: "Base" = None):
 
         viewer = Viewer()
         print(f"Unit: {self.unit}")
+        print(f"Using Linear Deflection: {linear_deflection}")
         viewer.unit = self.unit
         viewer.ui.sidebar.show_objectsetting = False
 
@@ -284,7 +285,7 @@ def parse_entity(entity, parent=None):
             name = f"[{entity.__class__.__name__}]{entity.Name}"
             transformation = Transformation.from_frame(entity.frame) if entity.frame else None
             if getattr(entity, "geometry", None) and not entity.is_a("IfcSpace"):
-                obj = viewer.scene.add(entity.geometry, name=name, parent=parent, hide_coplanaredges=True, **entity.style)
+                obj = viewer.scene.add(entity.geometry, name=name, parent=parent, hide_coplanaredges=True, **entity.style, linear_deflection=linear_deflection)
                 obj.transformation = transformation
             else:
                 obj = viewer.scene.add_group(name=name, parent=parent)
@@ -358,16 +359,6 @@ def remove(self, entity: Union["Base", list["Base"]]):
         """
         self.file.remove(entity)
 
-    def update_linear_deflection(self):
-        """Update the linear deflection tolerance settings in COMPAS based on the unit of the model."""
-        # TODO: deal with conversion based units like "FOOT"
-        if self.unit == "mm":
-            TOL.lineardeflection = 1
-        elif self.unit == "cm":
-            TOL.lineardeflection = 1e-1
-        elif self.unit == "m":
-            TOL.lineardeflection = 1e-3
-
     @classmethod
     def template(cls, schema: str = "IFC4", building_count: int = 1, storey_count: int = 1, unit: str = "mm", use_occ: bool = False) -> "Model":
         """Create a template model with a default project, site, building, and storey.