Merge pull request #33 from petrasvestartas/alias_and_unify_cycles

CHANGE aliases and unify_cycles.

Author: petrasvestartas

CHANGELOG.md

@@ -18,8 +18,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+* Add winding check in map_mesh function.
+
 ### Changed
 
+* Added meshpatter unify_cycles from COMPAS, LIBIGL has only triangle BFS.
+
 ### Removed
 
 
@@ -29,6 +33,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+* Removed C++ aliases to minimum.
+
 ### Removed
 
 * Removed all the types_std imports from the code. Instead type casters are used: https://nanobind.readthedocs.io/en/latest/exchanging.html .

docs/examples/example_mapping.py

@@ -102,7 +102,5 @@
 for i in range(mesh.number_of_vertices()):
     mesh_flattened.vertex_attributes(i, "xyz", [uv[i][0], uv[i][1], 0])
 
-json_dump([Mesh.from_vertices_and_faces(pv, pf), mesh_mapped, mesh_mapped_offset, boundaries, mesh_flattened], "mesh_flattened.json")
-
 viewer.scene.add(mesh_flattened, name="mesh_flattened")
 viewer.show()

mesh_flattened.json

@@ -1,7 +1,7 @@
 #include "boundaries.hpp"
 
-compas::VectorVectorInt trimesh_boundaries( Eigen::Ref<const compas::RowMatrixXi> F) {
-    compas::VectorVectorInt L;
+std::vector<std::vector<int>> trimesh_boundaries(Eigen::Ref<const compas::RowMatrixXi> F) {
+    std::vector<std::vector<int>> L;
     igl::boundary_loop(F, L);
     return L;
 }

src/boundaries.cpp

@@ -11,4 +11,4 @@
  *
  * @note The input mesh should be manifold for correct results.
  */
- compas::VectorVectorInt trimesh_boundaries(Eigen::Ref<const compas::RowMatrixXi> F);
+ std::vector<std::vector<int>> trimesh_boundaries(Eigen::Ref<const compas::RowMatrixXi> F);

src/boundaries.hpp

@@ -15,42 +15,25 @@
 #include <tuple>
 #include <iomanip>
 
-// Nanobind includes
+// Nanobind type casters: https://nanobind.readthedocs.io/en/latest/exchanging.html
+// If you want to bind a vector on your own, do not include compas.h, it will conflict with nanobind stl bindings.
 #include <nanobind/nanobind.h>
 #include <nanobind/eigen/dense.h>
 #include <nanobind/eigen/sparse.h>
 #include <nanobind/stl/tuple.h>
 #include <nanobind/stl/vector.h>
 #include <nanobind/stl/string.h>
-
+ 
+// Avoid any alias via using, unless really needed:
 namespace nb = nanobind;
-
 using namespace nb::literals;
 
-// Nanobind type casters: https://nanobind.readthedocs.io/en/latest/exchanging.html
-
 namespace compas {
-    // Basic Eigen types with clear naming
+    // Row-major matrix types for better interoperability with Python numpy arrays
     using RowMatrixXd = Eigen::Matrix<double, Eigen::Dynamic, Eigen::Dynamic, Eigen::RowMajor>;
     using RowMatrixXi = Eigen::Matrix<int, Eigen::Dynamic, Eigen::Dynamic, Eigen::RowMajor>;
-    using VectorXi = Eigen::VectorXi;
-    using VectorXd = Eigen::VectorXd;
-    
-    // STL containers with descriptive names
-    using VectorInt = std::vector<int>;
-    using VectorFloat = std::vector<float>;
-    using VectorBool = std::vector<bool>;
-    using VectorVectorInt = std::vector<VectorInt>;
-    
-    // Complex types with descriptive names
-    using TupleIntFloatFloatFloat = std::tuple<int, float, float, float>;  // face_id, u, v, t
-    using VectorTupleIntFloatFloatFloat = std::vector<TupleIntFloatFloatFloat>;
-    using VectorVectorTupleIntFloatFloatFloat = std::vector<VectorTupleIntFloatFloatFloat>;
 
-    // Tuple types with descriptive names
-    using IsolinesResult = std::tuple<RowMatrixXd, RowMatrixXi, RowMatrixXi>;  // vertices, edges, indices
-    using RemeshIsolineResult = std::tuple<RowMatrixXd, RowMatrixXi, VectorXi>;  // vertices, faces, labels
-    using RemeshIsolinesResult = std::tuple<RowMatrixXd, RowMatrixXi, VectorXd, VectorXi>;  // vertices, faces, scalar_values, face_groups
-    using PrincipalCurvatureResult = std::tuple<RowMatrixXd, RowMatrixXd, VectorXd, VectorXd>;  // PD1, PD2, PV1, PV2
-    using MeshMapResult = std::tuple<RowMatrixXd, VectorVectorInt, RowMatrixXd, VectorBool, VectorInt>;  // pattern_vertices, pattern_faces, pattern_normals, is_boundary, groups
+    // Vector types that maintain row-major storage for consistency
+    using RowVectorXd = Eigen::Matrix<double, 1, Eigen::Dynamic, Eigen::RowMajor>;
+    using RowVectorXi = Eigen::Matrix<int, 1, Eigen::Dynamic, Eigen::RowMajor>;
 }

src/compas.hpp

@@ -69,14 +69,14 @@ def map_mesh(target_mesh, pattern_mesh, clip_boundaries=True, simplify_borders=T
 
     Returns
     -------
-    tuple[ndarray, VectorVectorInt, ndarray, VectorBool, VectorInt]
+    tuple[np.array, list[list[int]], np.array, list[bool], list[int]]
         A tuple containing:
 
-        * vertices: ndarray - The 3D coordinates of the mapped mesh vertices
-        * faces: VectorVectorInt - The faces of the mapped mesh
-        * normals: ndarray - The normal vectors at each vertex
-        * boundary_flags: VectorBool - Boolean flags indicating if vertices are on the boundary
-        * polygon_groups: VectorInt - Grouping indices for polygons (to form holes)
+        * vertices: np.array - The 3D coordinates of the mapped mesh vertices
+        * faces: list[list[int]] - The faces of the mapped mesh
+        * normals: np.array - The normal vectors at each vertex
+        * boundary_flags: list[bool] - Boolean flags indicating if vertices are on the boundary
+        * polygon_groups: list[int] - Grouping indices for polygons (to form holes)
     """
     # Unpack mesh tuples
     v, f = target_mesh

src/compas_libigl/mapping.py

@@ -1,24 +1,27 @@
 #include "curvature.hpp"
 
 
-compas::PrincipalCurvatureResult
+std::tuple<compas::RowMatrixXd, 
+         compas::RowMatrixXd, 
+         Eigen::VectorXd, 
+         Eigen::VectorXd>
 trimesh_principal_curvature(
     Eigen::Ref<const compas::RowMatrixXd> V,
     Eigen::Ref<const compas::RowMatrixXi> F,
     int radius
 ) {
     compas::RowMatrixXd PD1, PD2;
-    compas::VectorXd PV1, PV2;
+    Eigen::VectorXd PV1, PV2;
     igl::principal_curvature(V, F, PD1, PD2, PV1, PV2, radius);
     return std::make_tuple(PD1, PD2, PV1, PV2);
 }
 
-compas::VectorXd
+Eigen::VectorXd
 trimesh_gaussian_curvature(
     Eigen::Ref<const compas::RowMatrixXd> V,
     Eigen::Ref<const compas::RowMatrixXi> F
 ) {
-    compas::VectorXd K;
+    Eigen::VectorXd K;
     igl::gaussian_curvature(V, F, K);
     return K;
 }

src/curvature.cpp

@@ -12,7 +12,7 @@
  * @param F The face matrix of the triangle mesh (m x 3).
  * @return A vector of gaussian curvature values per vertex.
  */
-compas::VectorXd trimesh_gaussian_curvature(
+Eigen::VectorXd trimesh_gaussian_curvature(
     Eigen::Ref<const compas::RowMatrixXd> V,
     Eigen::Ref<const compas::RowMatrixXi> F
 );
@@ -29,7 +29,10 @@ compas::VectorXd trimesh_gaussian_curvature(
  *         - PV1: principal curvature 1 per vertex (n x 1)
  *         - PV2: principal curvature 2 per vertex (n x 1)
  */
-compas::PrincipalCurvatureResult
+std::tuple<compas::RowMatrixXd, 
+         compas::RowMatrixXd, 
+         Eigen::VectorXd, 
+         Eigen::VectorXd>
 trimesh_principal_curvature(
     Eigen::Ref<const compas::RowMatrixXd> V,
     Eigen::Ref<const compas::RowMatrixXi> F,

src/curvature.hpp

@@ -1,13 +1,13 @@
 #include "geodistance.hpp"
 
 // Main entry points
-compas::VectorXd trimesh_geodistance(
+Eigen::VectorXd trimesh_geodistance(
     Eigen::Ref<const compas::RowMatrixXd> V,
     Eigen::Ref<const compas::RowMatrixXi> F,
     int source,
     const std::string& method
 ) {
-    compas::VectorXi sources(1);
+    Eigen::VectorXi sources(1);
     sources << source;
 
     if (method == "exact") {
@@ -19,10 +19,10 @@ compas::VectorXd trimesh_geodistance(
     throw std::runtime_error("Unknown method: " + method);
 }
 
-compas::VectorXd trimesh_geodistance_multiple(
+Eigen::VectorXd trimesh_geodistance_multiple(
     Eigen::Ref<const compas::RowMatrixXd> V,
     Eigen::Ref<const compas::RowMatrixXi> F,
-    Eigen::Ref<const compas::VectorXi> sources,
+    Eigen::Ref<const Eigen::VectorXi> sources,
     const std::string& method
 ) {
     if (sources.size() == 0) {
@@ -57,13 +57,13 @@ compas::VectorXd trimesh_geodistance_multiple(
 }
 
 // Implementation details
-compas::VectorXd trimesh_geodistance_exact(
+Eigen::VectorXd trimesh_geodistance_exact(
     const compas::RowMatrixXd& V,
     const compas::RowMatrixXi& F,
     int vid)
 {
-    compas::VectorXd D;
-    compas::VectorXi VS, FS, VT, FT;
+    Eigen::VectorXd D;
+    Eigen::VectorXi VS, FS, VT, FT;
 
     VS.resize(1);
     VS << vid;
@@ -75,12 +75,12 @@ compas::VectorXd trimesh_geodistance_exact(
     return D;
 }
 
-compas::VectorXd trimesh_geodistance_heat(
+Eigen::VectorXd trimesh_geodistance_heat(
     const compas::RowMatrixXd& V,
     const compas::RowMatrixXi& F,
     int vid)
 {
-    compas::VectorXi gamma;
+    Eigen::VectorXi gamma;
     gamma.resize(1);
     gamma << vid;